Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minswap Optimization & new Features after Certik Audit #35

Merged
merged 22 commits into from
Apr 16, 2024
Merged

Minswap Optimization & new Features after Certik Audit #35

merged 22 commits into from
Apr 16, 2024

Conversation

h2physics
Copy link
Member

@h2physics h2physics commented Feb 15, 2024 •
edited
Loading

  • Move Liquidity Pool batching logic to a new Withdrawal contract validate_pool_batching
  • Support Bi-directional Fee
  • Support Donation Order
  • Use constant 10000 as Fee Denominator
  • Allow anyone can create liquidity pools with trading fee between 0.05% -> 20%
  • Get rid of batcher and admin license and use Global Setting contract to store whitelisted batchers and admin
  • Optimize input_indexes by using ByteArray
  • Ad hoc swap value comparision

@h2physics
move Liquidity Pool logic to Pool batching Withdrawal contract (#31)
91a9eb7 
* move Liquidity Pool logic to Pool batching Withdrawal contract

* use inline datum for contracts except order

* refactor code

* add dynamic fee support

* fix test
@h2physics
feat: support bidirectional fee (#32)
d1e429b
@h2physics
Merge branch 'main' into develop
ef7f554
@h2physics
Merge branch 'main' into develop
0bf0d0c
@h2physics
Merge branch 'main' into develop
614cd9b
@h2physics
allow order can decide its amount by specific amount or relying on am…
8c8bf73 
…ount in its value and update spec doc (#37)

* allow order can decide its amount by specific amount or relying on amount in its value and update spec doc

* strict datum type of sender and receiver
@h2physics
add offchain testing (#40)
bec9038 
* add offchain testing

* remove unused file
@h2physics
Merge branch 'main' into develop
d3cab09
@h2physics
pump aiken ci
9532ee5
@h2physics
Merge branch 'main' into develop
9cb64ba
@h2physics
support donation order [MIN-532] (#42)
0aca2a9 
* support donation order

* update spec
@h2physics
change test admin policy id
aca3480
@h2physics
use 10000 as default fee denominator (#43)
5e8455e 
* use 10000 as default fee denominator

* fix docs and comment
@h2physics
Merge branch 'main' into develop
02985d1
@h2physics h2physics changed the title move Liquidity Pool logic to Pool batching Withdrawal contract & support bidirectional fee Minswap Optimization & new Features after Certik Audit Mar 8, 2024
@h2physics h2physics marked this pull request as ready for review March 31, 2024 10:50
h2physics and others added 5 commits April 2, 2024 14:12
@h2physics
Optimization from Anastasia Labs (#46)
7f45b4e 
* Optimization from Anastasia Labs

* adhoc compare swap value (#47)

* adhoc compare swap value

* add more comments

* resolve audit finding (#48)
@h2physics
remove redundant code
65f53ca
@h2physics
verify only pool script & author script (if have) is allowed on some …
d3ca598 
…pool's redeemers
@m1n999999
Test for math functions (#49)
7e09270
@h2physics
increase Pool Minimum ADA from 3 ADA to 4.5 ADA to buffer for ledger …
7cc7012 
…change and inline datum (#50)

* increase Pool Minimum ADA from 3 ADA to 4.5 ADA to buffer for ledger change and inline datum

* update script
@h2physics h2physics merged commit 6239e7e into main Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h2physics @m1n999999