Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): blueskyの投稿埋め込み表示に対応 #14933

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
2ebe003
enhance(frontend): blueskyの投稿埋め込み表示に対応
kakkokari-gtyih Nov 10, 2024
9bd7af5
Update Changelog
kakkokari-gtyih Nov 10, 2024
161e212
Merge branch 'develop' into feat-14931
kakkokari-gtyih Nov 11, 2024
558b62e
Merge branch 'develop' into feat-14931
kakkokari-gtyih Nov 13, 2024
a132b98
Merge branch 'develop' into feat-14931
kakkokari-gtyih Nov 15, 2024
8e01cc1
Merge branch 'develop' into feat-14931
saschanaz Nov 16, 2024
438cb63
unify *postExpanded
kakkokari-gtyih Nov 17, 2024
6df2a74
fix
kakkokari-gtyih Nov 17, 2024
eaaeeb1
Update MkUrlPreview.vue
kakkokari-gtyih Nov 18, 2024
5fbe273
Merge branch 'develop' into feat-14931
kakkokari-gtyih Nov 18, 2024
23610e8
unify postHeight
kakkokari-gtyih Nov 19, 2024
36199b6
Merge branch 'feat-14931' of https://github.com/kakkokari-gtyih/missk…
kakkokari-gtyih Nov 19, 2024
662bfd6
Merge branch 'develop' into feat-14931
kakkokari-gtyih Nov 19, 2024
723af2c
Merge branch 'develop' into feat-14931
kakkokari-gtyih Nov 21, 2024
6834d68
Merge branch 'develop' into feat-14931
kakkokari-gtyih Nov 23, 2024
3bc4690
Update CHANGELOG.md
kakkokari-gtyih Nov 23, 2024
bcca26b
Merge branch 'develop' into feat-14931
kakkokari-gtyih Nov 24, 2024
577237c
fix(frontend): ツイート埋め込み表示が閉じれない問題を修正
kakkokari-gtyih Nov 29, 2024
fdb3803
Merge branch 'feat-14931' of https://github.com/kakkokari-gtyih/missk…
kakkokari-gtyih Nov 29, 2024
037cfc3
Merge branch 'develop' into feat-14931
kakkokari-gtyih Dec 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Enhance: PC画面でチャンネルが複数列で表示されるように
(Cherry-picked from https://github.com/Otaku-Social/maniakey/pull/13)
- Enhance: 照会に失敗した場合、その理由を表示するように
- Enhance: Blueskyの投稿埋め込みプレビューに対応
- Fix: 画面サイズが変わった際にナビゲーションバーが自動で折りたたまれない問題を修正
- Fix: サーバー情報メニューに区切り線が不足していたのを修正
- Fix: ノートがログインしているユーザーしか見れない場合にログインダイアログを閉じるとその後の動線がなくなる問題を修正
Expand Down
2 changes: 1 addition & 1 deletion locales/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2585,7 +2585,7 @@ export interface Locale extends ILocale {
/**
* ポストを展開する
*/
"expandTweet": string;
"expandPost": string;
/**
* テーマエディター
*/
Expand Down
2 changes: 1 addition & 1 deletion locales/ja-JP.yml
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,7 @@ poll: "アンケート"
useCw: "内容を隠す"
enablePlayer: "プレイヤーを開く"
disablePlayer: "プレイヤーを閉じる"
expandTweet: "ポストを展開する"
expandPost: "ポストを展開する"
themeEditor: "テーマエディター"
description: "説明"
describeFile: "キャプションを付ける"
Expand Down
103 changes: 84 additions & 19 deletions packages/frontend/src/components/MkUrlPreview.vue
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,34 @@ SPDX-License-Identifier: AGPL-3.0-only
</MkButton>
</div>
</template>
<template v-else-if="tweetId && tweetExpanded">
<div ref="twitter">
<template v-else-if="tweetId && postExpanded">
<div>
<iframe
ref="tweet"
allow="fullscreen;web-share"
sandbox="allow-popups allow-popups-to-escape-sandbox allow-scripts allow-same-origin"
scrolling="no"
:style="{ position: 'relative', width: '100%', height: `${tweetHeight}px`, border: 0 }"
:style="{ position: 'relative', width: '100%', height: `${postHeight}px`, border: 0 }"
:src="`https://platform.twitter.com/embed/index.html?embedId=${embedId}&amp;hideCard=false&amp;hideThread=false&amp;lang=en&amp;theme=${defaultStore.state.darkMode ? 'dark' : 'light'}&amp;id=${tweetId}`"
></iframe>
</div>
<div :class="$style.action">
<MkButton :small="true" inline @click="tweetExpanded = false">
<MkButton :small="true" inline @click="postExpanded = false">
<i class="ti ti-x"></i> {{ i18n.ts.close }}
</MkButton>
</div>
</template>
<template v-else-if="bskyDid && bskyPostRecordKey && postExpanded">
<div>
<iframe
allow="fullscreen;web-share"
sandbox="allow-popups allow-popups-to-escape-sandbox allow-scripts allow-same-origin"
scrolling="no"
:style="{ position: 'relative', width: '100%', height: `${postHeight}px`, border: 0 }"
:src="`https://embed.bsky.app/embed/${bskyDid}/app.bsky.feed.post/${bskyPostRecordKey}?id=${embedId}`"
></iframe>
</div>
<div :class="$style.action">
<MkButton :small="true" inline @click="postExpanded = false">
<i class="ti ti-x"></i> {{ i18n.ts.close }}
</MkButton>
</div>
Expand Down Expand Up @@ -66,8 +81,13 @@ SPDX-License-Identifier: AGPL-3.0-only
</component>
<template v-if="showActions">
<div v-if="tweetId" :class="$style.action">
<MkButton :small="true" inline @click="tweetExpanded = true">
<i class="ti ti-brand-x"></i> {{ i18n.ts.expandTweet }}
<MkButton :small="true" inline @click="postExpanded = true">
<i class="ti ti-brand-x"></i> {{ i18n.ts.expandPost }}
</MkButton>
</div>
<div v-if="bskyPostRecordKey" :class="$style.action">
<MkButton :small="true" inline @click="openBskyEmbed">
<i class="ti ti-brand-bluesky"></i> {{ i18n.ts.expandPost }}
</MkButton>
</div>
<div v-if="!playerEnabled && player.url" :class="$style.action">
Expand Down Expand Up @@ -126,10 +146,17 @@ const player = ref({
height: null,
} as SummalyResult['player']);
const playerEnabled = ref(false);
const tweetId = ref<string | null>(null);
const tweetExpanded = ref(props.detail);

const embedId = `embed${Math.random().toString().replace(/\D/, '')}`;
const tweetHeight = ref(150);
const postExpanded = ref(props.detail);
const postHeight = ref(150);

const tweetId = ref<string | null>(null);

const bskyHandleOrDid = ref<string | null>(null);
const bskyDid = ref<string | null>(null);
const bskyPostRecordKey = ref<string | null>(null);

const unknownUrl = ref(false);

onDeactivated(() => {
Expand All @@ -144,6 +171,19 @@ if (requestUrl.hostname === 'twitter.com' || requestUrl.hostname === 'mobile.twi
if (m) tweetId.value = m[1];
}

if (requestUrl.hostname === 'bsky.app') {
const bskyPostPageUrl = requestUrl.pathname.slice(1).split('/');

if (bskyPostPageUrl[0] === 'profile' && bskyPostPageUrl[1] && bskyPostPageUrl[2] === 'post' && bskyPostPageUrl[3]) {
bskyHandleOrDid.value = bskyPostPageUrl[1];
bskyPostRecordKey.value = bskyPostPageUrl[3];

if (postExpanded.value) {
openBskyEmbed();
}
}
}

if (requestUrl.hostname === 'music.youtube.com' && requestUrl.pathname.match('^/(?:watch|channel)')) {
requestUrl.hostname = 'www.youtube.com';
}
Expand Down Expand Up @@ -180,13 +220,23 @@ window.fetch(`/url?url=${encodeURIComponent(requestUrl.href)}&lang=${versatileLa
sensitive.value = info.sensitive ?? false;
});

function adjustTweetHeight(message: MessageEvent) {
if (message.origin !== 'https://platform.twitter.com') return;
const embed = message.data?.['twttr.embed'];
if (embed?.method !== 'twttr.private.resize') return;
if (embed?.id !== embedId) return;
const height = embed?.params[0]?.height;
if (height) tweetHeight.value = height;
async function openBskyEmbed() {
if (bskyHandleOrDid.value == null || bskyPostRecordKey.value == null) return;

if (bskyDid.value == null) {
if (bskyHandleOrDid.value.startsWith('did:')) {
bskyDid.value = bskyHandleOrDid.value;
} else {
// handleで来ている場合はdidに変換
const bskyApiRes = await window.fetch(`https://public.api.bsky.app/xrpc/com.atproto.identity.resolveHandle?handle=${bskyHandleOrDid.value}`);
if (bskyApiRes.ok) {
const bskyApiData = await bskyApiRes.json() as { did: string };
bskyDid.value = bskyApiData.did;
}
}
}

postExpanded.value = true;
}

function openPlayer(): void {
Expand All @@ -199,10 +249,25 @@ function openPlayer(): void {
});
}

window.addEventListener('message', adjustTweetHeight);
function adjustSocialsEmbedHeight(message: MessageEvent) {
if (message.origin === 'https://platform.twitter.com') {
const embed = message.data?.['twttr.embed'];
if (embed?.method === 'twttr.private.resize' && embed?.id === embedId) {
const height = embed?.params[0]?.height;
if (height) postHeight.value = height;
}
} else if (message.origin === 'https://embed.bsky.app') {
if (message.data?.id === embedId) {
const height = message.data?.height;
if (height) postHeight.value = height;
}
}
}

window.addEventListener('message', adjustSocialsEmbedHeight);

onUnmounted(() => {
window.removeEventListener('message', adjustTweetHeight);
window.removeEventListener('message', adjustSocialsEmbedHeight);
});
</script>

Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
style-src 'self' 'unsafe-inline';
img-src 'self' data: blob: www.google.com xn--931a.moe localhost:3000 localhost:5173 127.0.0.1:5173 127.0.0.1:3000;
media-src 'self' localhost:3000 localhost:5173 127.0.0.1:5173 127.0.0.1:3000;
connect-src 'self' localhost:3000 localhost:5173 127.0.0.1:5173 127.0.0.1:3000 https://newassets.hcaptcha.com;
connect-src 'self' localhost:3000 localhost:5173 127.0.0.1:5173 127.0.0.1:3000 https://newassets.hcaptcha.com https://public.api.bsky.app;
frame-src *;"
/>
<meta property="og:site_name" content="[DEV BUILD] Misskey" />
Expand Down
Loading