Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example file issues #7

Open
DanielAbalde opened this issue Apr 16, 2021 · 1 comment
Open

Example file issues #7

DanielAbalde opened this issue Apr 16, 2021 · 1 comment

Comments

@DanielAbalde
Copy link

Hi, I know it is a WIP project, but let me share the issues that I found checking the example files so it can help you to make quick fixes.

  1. When I open each file I got "Input parameter chunk is missing. Archive is corrupt." gh messages.

  2. SampleScriptVanilla.gh doesn't contain any of your components, it is this intentional?

  3. Openning SampleScriptHardCoded.gh I got an OutOfRange exception (SettersDefineComponent class, line 50), since the merge component only receive 2 values instead of 3. IMO you should include a component error if ids.Count != vals.Count instead of let GH (or VS while debugging) handle this error, because normal users won't know what's going on. I am adding these validators myself in case you want to do a merge later.

  4. The file CreateInterfaceComplex.gh contains what it seams other version of text component called "Create Label", which its last input is "css" but the data type is number so it throws a conversion error. It is fixed in CreateInterfaceMoreComplex.gh file.

  5. Closing windows doesn't work until I set to false the show input.

  6. It is compiled for RH7, there is some reason or it can be compiled for RH6 as well?

  7. Components with Id input, should not be empty as default and optional? It is confusing having id="slider".

  8. Components with name input, should not be its component name rather than "slider"?

  9. As a suggestion that I bet you already thought, components to have css preset styles.

@DanielAbalde
Copy link
Author

Also I think you should put the example files outside the source code, since those files have personal variables (as file paths).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant