Implemented UART in accordance with the API definition in softuart.h to allow the example code to access printf() functionality #18

RacingTornado · 2016-06-24T08:00:29Z

git clone https://github.com/RacingTornado/fx2lib
cd fx2lib
make
For fast_uart , git checkout branch_name
make
cd examples/uart_main
make
./download.sh build/uart_main.ihx

sudo minicom -H -w fastuart

You should have the parameters of fastuart set to 115200. You should see the values on the terminal.

The PA2 pin must be connected to the rx pin on the serial adaptor. In this situation , the ground must be the same also. Else you may get receiving errors.

The idea is to use this for debugging purposes. The baud rates is set to 115200 by setting the delay values.

Another important fact is that the console must be first opened up before loading the firmware onto the FX2. This is required for getting a lock on the start and the stop bits since there is no line break attached between the 2 bytes.

Code has been cleaned up and the firmware in the examples directory is extremely small(less than 5-6 lines)
Assembly has been extensively commented.
I would like to merge this with the linux-descriptors branch since this is what I used as a base

mithro · 2016-06-24T11:57:09Z

This is starting down the right path, but there are a couple of big things which need to change.

As I described in my email, there should be a function / macro something like CREATE_FAST_UART(<uart name>, <tx pin>). Calling this should generate a bunch of functions with names like uart0_init, uart0_rx etc (assuming <uart name> was set to uart0).

This allows you to create two uarts on two different pins which can be used at the same time.

Your comments about the API are misleading too. It very much does matter what you return for the queue count.

When commenting your ASM, you should align things like cycle counts above each other.

mithro · 2016-06-24T11:57:52Z

Please write your setup/testing instructions in the form of valid shell commands too.

mithro · 2016-06-24T11:58:32Z

examples/uart_main/uart_main.c

+#include <stdio.h>
+#include <uart/api.h>
+
+//Used for setting the baud rate.


Don't define things you are not using at the moment.

RacingTornado · 2016-06-24T13:06:06Z

This allows you to create two uarts on two different pins which can be used at the same time

I am a little confused as to how you plan to achieve this.
#define something(name,func) name##some"()"
something(hello,1)
From what locations so you plan to call this. I am not sure I understand this feature completely. Wont it just be better to have a function which sets the pin in api.h and implement this since the function fast_uart blocks anyway. I dont seem to understand "same_time" means in this context

RacingTornado · 2016-06-25T02:03:34Z

When commenting your ASM, you should align things like cycle counts above each other.

This is kind of hard but I have tried doing it

mithro · 2016-06-25T05:00:54Z

Try taking a look at the following regarding cycle comments;

mithro · 2016-06-25T05:03:15Z

lib/uart/soft_uart.c

+
+BOOL uartX_set_baud(enum uart_baud rate)
+{
+    switch(rate)


I actually didn't mean for you to implement all the baud rates, just to return an error when the baud rate was not BAUD_115200. However, as you have already done it now we can leave it here.

mithro · 2016-07-03T07:15:25Z

examples/uart_main/download.sh

@@ -0,0 +1,15 @@
+#!/bin/bash -e


This download script should probably be shared between all examples. Can you move it into the examples directory and send it as a separate pull request.

You could then have it as part of the common Makefile..

mithro · 2016-07-03T07:16:49Z

examples/uart_main/uart_main.c

+void main(void)
+{
+    baud = BAUD_115200;
+    uartX_init(baud);


These should be called "uart0_init" as we discussed? Are you waiting on something from me?

I still have a question. If I call printf(), how does it know which uart to connect to.

You will need a function in the firmware which maps puts to the correct uart function?

putchar() can be mapped to one uart.How do we do this for more than 1 and dynamically? Once again I think things would be easier once I create and commit the macro.

Fixed in the latest commit.

mithro · 2016-07-03T07:33:01Z

This still need a bunch of work before it can be merged.

Couple of things which need to be done are;

Test with two UARTs.
How fast can this UART operate if you don't have any delays?
If you don't disable the ISR and is the corruption detectable?

As I mentioned previously, this UART is mainly for debugging -- so we want it to be fast and have minimal impact on the system. This probably means we are going to be okay with using a non-standard BAUD rate here.

mithro · 2016-07-03T07:35:12Z

examples/uart_main/uart_main.c

+    SETCPUFREQ(CLK_48M);
+    while (TRUE)
+    {
+        printf("Hello");


Add a \r\n to the printed string

RacingTornado · 2016-07-05T05:31:42Z

include/uart/soft_uart.h

+OEA = bitnum;							\
+uart_tx(c);							\
+}								\
+BOOL uartname##_set_baud(enum uart_baud rate) {			\


There is something funky. On gedit it is aligned(using tabs). Which editor do you want to use? Autoindenting in astyle is not able to align the \

I don't care what editor you use. I care that you set up your editor to produce the correct result. If you find it too hard to do that in gedit, you are welcome to try a different one.

I personally use vim, but it has a very steep learning curve.

It looks like only this diff view is showing this. The normal file here is https://github.com/RacingTornado/fx2lib/blob/9b86ebfe1bb807bdca802db8da0f271c2ed574e5/include/uart/soft_uart.h looks okay

The normal file is also showing the weird wrapping.

It is not showing it for me . I sent you an email with a picture.

mithro · 2016-07-11T04:44:13Z

examples/uart_main/Makefile

+DSCR_AREA=
+INT2JT=
+include $(FX2LIBDIR)/lib/fx2.mk
+fx2_download:


This target should be part of fx2.mk file?

mithro · 2016-07-11T04:52:47Z

This code still needs a whole bunch more work and I'm pretty sure if it does work, it is only by accident.

RacingTornado · 2016-07-11T05:20:18Z

This code still needs a whole bunch more work and I'm pretty sure if it does work, it is only by accident.

Why do you say that ? I use this extensively for debugging all my other stuff and it seems very reliable.

RacingTornado · 2016-07-21T03:58:19Z

include/uart/soft_uart.h

+ * uart name .
+ **/
+#define CREATE_FAST_UART(uartname,port,pinname,bitnum,TX_BLOCKING,RX_ENABLED)	\
+unsigned char uartname##_load_delay;											\


Last 2 are caps because they are TRUE or FALSE values

RacingTornado changed the title ~~Created a UART API definition in softuart.h to allow the example code to access printf() and scanf() functionality~~ Implemented UART in keeping with the API definition in softuart.h to allow the example code to access printf() and scanf() functionality Jun 24, 2016

mithro reviewed Jun 24, 2016
View reviewed changes

RacingTornado force-pushed the fast_uart_try3 branch from 01fcdd0 to 0803a71 Compare June 25, 2016 02:05

mithro reviewed Jun 25, 2016
View reviewed changes

RacingTornado force-pushed the fast_uart_try3 branch 6 times, most recently from 4f4d855 to 5076805 Compare June 25, 2016 13:14

mithro reviewed Jul 3, 2016
View reviewed changes

RacingTornado force-pushed the fast_uart_try3 branch 4 times, most recently from 7ce523c to 82ae218 Compare July 5, 2016 05:26

RacingTornado reviewed Jul 5, 2016
View reviewed changes

RacingTornado force-pushed the fast_uart_try3 branch from 82ae218 to 9b86ebf Compare July 5, 2016 13:12

mithro reviewed Jul 11, 2016
View reviewed changes

RacingTornado force-pushed the fast_uart_try3 branch 2 times, most recently from da356b1 to 614a4c3 Compare July 20, 2016 05:52

RacingTornado reviewed Jul 21, 2016
View reviewed changes

Create UART functions using C macros according to the api.h file.

d0519f9

RacingTornado force-pushed the fast_uart_try3 branch from 473cfb4 to d0519f9 Compare August 1, 2016 04:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented UART in accordance with the API definition in softuart.h to allow the example code to access printf() functionality #18

Implemented UART in accordance with the API definition in softuart.h to allow the example code to access printf() functionality #18

RacingTornado commented Jun 24, 2016

mithro commented Jun 24, 2016

mithro commented Jun 24, 2016

mithro Jun 24, 2016

RacingTornado commented Jun 24, 2016 •

edited

Loading

RacingTornado commented Jun 25, 2016 •

edited

Loading

mithro commented Jun 25, 2016

mithro Jun 25, 2016

mithro Jul 3, 2016

mithro Jul 3, 2016

RacingTornado Jul 4, 2016

mithro Jul 3, 2016

RacingTornado Jul 4, 2016

mithro Jul 4, 2016

RacingTornado Jul 4, 2016

RacingTornado Jul 5, 2016

mithro commented Jul 3, 2016

mithro Jul 3, 2016

RacingTornado Jul 4, 2016

RacingTornado Jul 5, 2016

mithro Jul 5, 2016

RacingTornado Jul 5, 2016

mithro Jul 11, 2016

RacingTornado Jul 11, 2016 •

edited

Loading

mithro Jul 11, 2016

mithro Jul 11, 2016

RacingTornado Jul 11, 2016

mithro commented Jul 11, 2016

RacingTornado commented Jul 11, 2016 •

edited

Loading

RacingTornado Jul 21, 2016

Implemented UART in accordance with the API definition in softuart.h to allow the example code to access printf() functionality #18

Are you sure you want to change the base?

Implemented UART in accordance with the API definition in softuart.h to allow the example code to access printf() functionality #18

Conversation

RacingTornado commented Jun 24, 2016

mithro commented Jun 24, 2016

mithro commented Jun 24, 2016

Choose a reason for hiding this comment

RacingTornado commented Jun 24, 2016 • edited Loading

RacingTornado commented Jun 25, 2016 • edited Loading

mithro commented Jun 25, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mithro commented Jul 3, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RacingTornado Jul 11, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mithro commented Jul 11, 2016

RacingTornado commented Jul 11, 2016 • edited Loading

Choose a reason for hiding this comment

RacingTornado commented Jun 24, 2016 •

edited

Loading

RacingTornado commented Jun 25, 2016 •

edited

Loading

RacingTornado Jul 11, 2016 •

edited

Loading

RacingTornado commented Jul 11, 2016 •

edited

Loading