Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): Resolve bad invocation shell #8

Merged
merged 1 commit into from
May 16, 2024
Merged

fix(build): Resolve bad invocation shell #8

merged 1 commit into from
May 16, 2024

Commits on May 16, 2024

  1. fix(build): Resolve bad shell invocation shell 

    Before, during the building procedure, there was a problem with the invocation shell in the child process that used `child_process.spawn`. In Windows, this resulted in the process issuing an ENOENT error since the command was not recognized. However, with this modification, we resolved the issue and it now functions correctly in Windows by activating the `shell` option within the options argument (3rd argument) of the `spawn` function.

Note:
Tested in PowerShell and MSYS2 MinTTY. This change are exclusively to Windows users and developers.
    @mitsuki31
    mitsuki31 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f5dc677 View commit details
    Browse the repository at this point in the history