add arm support #83
Merged
add arm support #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-helmich
requested changes
Dec 11, 2024
.github/workflows/release.yaml
Outdated
Comment on lines
28
to
37
| - name: Build binaries for ${{ matrix.arch }} | ||
| run: | | ||
| mkdir -p dist | ||
| go build -o dist/myapp-${{ matrix.arch }} . | ||
|
|
||
| - name: Upload binaries | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: binaries-${{ matrix.arch }} | ||
| path: dist/myapp-${{ matrix.arch }} |
There was a problem hiding this comment.
Goreleaser already builds the binaries and images for all required architectures. A separate Github matrix build is not necessary.
There was a problem hiding this comment.
i means that the change is obsolet? Can you help me please to finish adding arm build support?
There was a problem hiding this comment.
Depends; if you only need the binaries, your additional entry in .goreleaser.yml is sufficient. If you need a multi-arch Docker image, this would be a bit more work (look at the .goreleaser.yml of the mittwald/kubernetes-replicator project for reference).
There was a problem hiding this comment.
i only need arm64 binary, i reverted other changes
martin-helmich
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.