-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/force unbond #96
Open
karapetyantv
wants to merge
44
commits into
main
Choose a base branch
from
feat/force-unbond
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resets ledger's current nominations. Funds remain bonded.
This contact serves as a new Lido contract implementation which will contain updates for the forced unbond logic
New modifier allows to restrict calls to the redeem() method. Separate modifier apart from whenNotPaused is required since whenNotPaused affects the claimUnbonded() method as well
Set target stake to 0 if unbond was forced
Instead of refereshing infinite approval from Withdrwal to Lido forcefully unbonded funds are now transfered directly from Withdrawal to msg.sender
Redeems are now enabled by default
Otherwise contracts bytocode is not compliant with EIP-170 The method won't be used after lido sunset update
Initially redeem only for half of the st token balance. After Lido implementation update redeem remaining funds. Additionally rewards are distributed after redeeming second part
claimForcefullyUnbonded() must not allow claiming funds until unbonding chunks for it have matured
For forced unbond we want to consider a case when losses and rewards were scheduled before the chill but actually applied afterwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.