Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beatloop size: keep loop end, adjust loop start in UI by right-clicking on up/down buttons? #12610

Closed
mxmilkiib opened this issue Jan 21, 2024 · 2 comments

Comments

@mxmilkiib
Copy link
Contributor

Feature Description

One can adjust the loop-out marker forwards and back by left clicking on the up and down arrows next to the size number.

How about moving the loop in marker back and forth by right clicking the same buttons?

Instead of showing a right-click context menu.

This would allow for more creative opportinuties.

@ronso0
Copy link
Member

ronso0 commented Jan 21, 2024

Sounds reasonable.

Note for all those who want to tackle this:
IMO squeezing this into WBeatSpinBox (used for both beatloop_size and beatjump_size) is rather complex since it can't be done with how the size control value change is currently transmitted to LoopingControl.
First obstacle: both button up/down clicks and Up/Down keyboard presses call WBeatSpinBox::stepBy, there one would somehow need to check if Shift is pressed.
Second, LoopingControl would need to know about "keep loop end position".

IMO, in order to make this available both in the GUI and for other controls (controllers) we need to

  • create loop_halve/double_keep_end controls
  • create separate Halve/Double buttons next to the spinbox
  • hide the spinbox' up/down buttons with setButtonSymbols(QAbstractSpinBox::NoButtons);, depending on widget attribute <ShowButtons> (default true), so custom and legacy skins are not affected

This would make the decks grow so we also need to increase e.g. LateNight's minimum size.

Related: #11969

@ronso0 ronso0 changed the title Beetloop size: adjust loop start marker in UI by right-clicking on up/down chevrons? Beetloop size: keep loop end, adjust loop start in UI by right-clicking on up/down buttons? Jan 21, 2024
@ronso0 ronso0 changed the title Beetloop size: keep loop end, adjust loop start in UI by right-clicking on up/down buttons? Beatloop size: keep loop end, adjust loop start in UI by right-clicking on up/down buttons? May 19, 2024
@ronso0
Copy link
Member

ronso0 commented May 19, 2024

Fixed by #12745 isn't it?

Feel free to reopen in case I missed some aspect.

@ronso0 ronso0 closed this as completed May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants