SoundManager: Set up AVAudioSession on iOS
#12714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
force-pushed
the
ios-avaudiosession
branch
from
02f0381
to
d34ab92
Compare
daschuer
reviewed
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #12672
On iOS, audio apps should set up an
AVAudioSessionto tailor the OS behavior towards their use case (e.g. whether the app should interrupt other audio etc.) As explained in PortAudio/portaudio#881, this is currently not handled by PortAudio and likely doesn't fit into its API, since different apps will have different requirements that can't be handled by a "one-size-fits-all" initialization.For Mixxx, I've set up the session in a way that it mixes with other apps1 and uses the standard playback mode.
Footnotes
Not strictly necessary, but since we're mixing our own decks anyway, I see no downside in mixing with other apps too? Also, we wouldn't interrupt audio when launching Mixxx that way (an alternative would be to activate the audio session first upon playing a track, but that would likely require the
AVAudioSessionlogic to be more deeply intertwined with other playback logic, which might not be desirable in order to keep platform-specific stuff isolated). ↩