Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metronome: Fix noise when pausing track in in the middle of the click sound. #13733

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Oct 8, 2024

Continue to play started metronome click even if track is paused.
This fixes repeating the same buffer over and over again causing loud noise.

#13727

This fixes repeating the same buffer over and over again causing loud noise.
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you. will rebase #13654 shortly (for which I would appreciate a review).

@Swiftb0y Swiftb0y merged commit c38753d into mixxxdj:2.4 Oct 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants