fix: prevent null CO access when cloning sampler or preview #13740
Conversation
| (deckToClone->m_stemGain.empty() && | ||
| deckToClone->m_stemMute.empty())) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
The verify blow includes this check and sticks around at release time. So this check can be removed.
There was a problem hiding this comment.
It does but it's not equivalent.
Having the two vector empty is an expected case, for which we do an early return. The assert condition adds extra usecase that would crash the for-loop but are not expected usecase on which we should assert.
I agree that this would technically add couple of extra instructions at release time, but since this function is not time critical, I would suggest we keep the clear distinction between the early return on excepted usecase, and protective return on unexpected case.
There was a problem hiding this comment.
Ah I see. How about replacing the first loop by
If (isPrimaryDeck())?
There was a problem hiding this comment.
That sounds much cleaner indeed. Updated.
No description provided.