Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for the "Korg Kaoss DJ" controller script #4301

Closed

Conversation

raphaelquast
Copy link
Contributor

@raphaelquast raphaelquast commented Sep 18, 2021

New assignments:

browser Knob browse library or playlist up & down (same as before)
shift + browser Knob toggle focus between Playlist and File-Browser
tap open folder
2 x tap close folder
(left) shift + tap tap bpm of left track
(right) shift + tap tap bpm of right track
load A / B load track to deck 1 / 2 (same as before)
shift + load A / B open / close folder in file-browser
shift + touchpad X control super knob of QuickEffectRack for deck 1
shift + touchpad Y control super knob of QuickEffectRack for deck 2

changed assignments

  • the loop-on button now works as follows:
    • if a loop is active, it deactivates the loop (same as before)
    • if no loop is active, a new beatloop is created at the current playback position
      (before a re-loop of the deactivated loop was triggered)

doc-updates:

mixxxdj/manual#430

<TAP>                : open folder
<TAP> + <TAP>        : double-tap to close folder
<SHIFT LEFT> + <TAP> : tap bpm of LEFT track
<SHIFT RIGHT> + <TAP> : tap bpm of RIGHT track

<browseKnob>           : browse library up & down
<SHIFT> + <browseKnob> : toggle focus between Playlist and File-Browser

<LOAD A/B>           : load track
<SHIFT> + <LOAD A/B> : open/close folder in file-browser
<SHIFT> + <TOUCHPAD X> : control super knob of QuickEffectRack for deck 1
<SHIFT> + <TOUCHPAD Y> : control super knob of QuickEffectRack for deck 2
raphaelquast added a commit to raphaelquast/manual that referenced this pull request Sep 18, 2021
@Swiftb0y
Copy link
Member

Please install pre-commit and rerun it on the changed files. Thanks. Feel free to ask on zulip if you need help.

@raphaelquast
Copy link
Contributor Author

@Swiftb0y i ran pre-commit and fixed all syntax errors..
however I'm unsure how to deal with the remaining no-unused-vars errors since they complain about the call-signatures of the callback functions

@Swiftb0y
Copy link
Member

Thank you.

however I'm unsure how to deal with the remaining no-unused-vars errors since they complain about the call-signatures of the callback functions

Eslint is is configured to allow unused variables and parameters that start with an underscore (_). So just prefix those parameters with _ and eslint should not complain.

@Swiftb0y
Copy link
Member

Also, keep in mind that there is some variety in those rules, so for instance in this case, its likely fine to just remove the parameter entirely.

16:5 error 'led' is assigned a value but never used no-unused-vars

@raphaelquast
Copy link
Contributor Author

Eslint is is configured to allow unused variables and parameters that start with an underscore (_). So just prefix those parameters with _ and eslint should not complain.

OK I'll do that!

Also, keep in mind that there is some variety in those rules, so for instance in this case, its likely fine to just remove the parameter entirely.

16:5 error 'led' is assigned a value but never used no-unused-vars

I know... that variable is still from the original creator of the script so I don't want to remove it entirely...
I might just leave it there as a comment (it depicts the MIDI messages of the controller-buttons)

@uklotzde
Copy link
Contributor

As a First-time contributor we have to ask you to sign the Mixxx Contributor Agreement before merging any contributions.

@raphaelquast
Copy link
Contributor Author

As a First-time contributor we have to ask you to sign the Mixxx Contributor Agreement before merging any contributions.

OK, it's signed!

@github-actions
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Dec 21, 2021
@pi43r
Copy link
Contributor

pi43r commented Apr 27, 2022

Just curious why this was not merged?
I think the assignment fixes some previous todos and is an overall improvement.

@raphaelquast
Copy link
Contributor Author

hey @pi43r, there are some formatting issues with the updated documentation (mixxxdj/manual#430) and then it somewhat got lost because I had a lot of other things to do...

I'm not sure when I find some time to get the docs fixed, (even though it should only be some minor changes)

@github-actions github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Apr 28, 2022
@uklotzde uklotzde mentioned this pull request Jun 9, 2023
@github-actions
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Sep 13, 2023
@ronso0
Copy link
Member

ronso0 commented May 26, 2024

#12683 has been merged, closing this.

@ronso0 ronso0 closed this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller mappings stale Stale issues that haven't been updated for a long time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants