Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[portaudio] Add iOS patches #111

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Feb 5, 2024

This adds PortAudio/portaudio#881 to PortAudio, enabling builds targeting iOS. Once upstreamed, these patches can be removed.

@fwcd fwcd added the enhancement New feature or request label Feb 5, 2024
@fwcd fwcd mentioned this pull request Feb 5, 2024
54 tasks
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green. How is the IOS branch compiled? Can we cross-compile it like the M1 build?

@daschuer daschuer merged commit bcf8ed3 into mixxxdj:2.5 Feb 5, 2024
2 checks passed
@fwcd fwcd deleted the mixxx/portaudio-ios branch February 5, 2024 20:21
@fwcd
Copy link
Member Author

fwcd commented Feb 5, 2024

Pretty much, most packages should build by just targeting arm64-ios(-release)

@daschuer
Copy link
Member

daschuer commented Feb 5, 2024

Do you plan to add a CI runner for this?

@fwcd
Copy link
Member Author

fwcd commented Feb 5, 2024

Yes. There are some more missing patches for it to run through, but I'll see if I can open a PR soon.

@fwcd
Copy link
Member Author

fwcd commented Feb 5, 2024

Cross-compiling Qt for arm64 iOS will likely be similar to arm64 macOS in that debug builds will likely not be feasible. How would you suggest doing this under the current branching scheme? Should we add arm64-ios-release CI to both 2.5 and 2.5-rel, or just 2.5-rel?

@daschuer
Copy link
Member

daschuer commented Feb 5, 2024

With the package cache, incremental builds are possible. So we may need two attempts to have everything build.
But do we relay need the debug build? If not let's save some energy and only introduce the arm64-ios-release.
We can add the debug builds at any time later.

@fwcd
Copy link
Member Author

fwcd commented Feb 5, 2024

Yeah, my question was more around the branching scheme (IMO release builds are perfectly sufficient), i.e. whether we should add iOS (arm64-ios-release) CI to the (non-rel) 2.5 branch too? If so, should we add CI for arm64-osx-release to 2.5 too, which currently is only tested in 2.5-rel?

@daschuer
Copy link
Member

daschuer commented Feb 5, 2024

That's a good idea. This is now possible with the new scheme and we can uses it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants