Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libdjinterop] Update to 0.22.1 for 2.4 #147

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

JoergAtGithub
Copy link
Member

Cherry picked from microsoft#41251

@daschuer
Copy link
Member

daschuer commented Oct 2, 2024

We are already passed the 2.4.2 and 2.5.0 deadline. This PR requires and update of the macOS build environment requiring a whole world rebuild. Not sure if this is worth the effort or risk.
How important is fixing mixxxdj/mixxx#13695 in 2.4.2?
If we desice for it we need to backport the two CI commits from: #146

@daschuer
Copy link
Member

daschuer commented Oct 2, 2024

All green. That's good. unfortunately we have no experience yet with the macOS update, because the changes are not yet part of the 2.5 beta.
Is this a risk?

@JoergAtGithub
Copy link
Member Author

Isn't this the same as mixxxdj/mixxx#13296 ? If there is a macOS 12 problem, we're affected in 2.4.2 anyway.

@daschuer
Copy link
Member

daschuer commented Oct 3, 2024

Ok than let's merge. Thank you for taking care.

@daschuer daschuer merged commit df95974 into mixxxdj:2.4 Oct 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants