Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4 build fix #99

Merged
merged 3 commits into from
Nov 16, 2023
Merged

2.4 build fix #99

merged 3 commits into from
Nov 16, 2023

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Nov 15, 2023

This fixes building after GitHub has updated the macos11 workflow runner.
2.5 is not affected because Qt 6 no longer depends on fontconfig

@daschuer daschuer changed the title 2.4 build 2.4 build fix Nov 15, 2023
@fwcd
Copy link
Member

fwcd commented Nov 15, 2023

Ah neat, thanks for investigating this, I ran into this in my 2.4 build too: fwcd/m1xxx#54 (though the failure is of course not related to the renaming)!

fwcd added a commit to fwcd/m1xxx that referenced this pull request Nov 15, 2023
CMake Error at scripts/cmake/vcpkg_find_acquire_program.cmake:619 (message):
  Could not find nasm.  Please install it via your package manager:

      brew install nasm
Call Stack (most recent call first):
  ports/ffmpeg/portfile.cmake:31 (vcpkg_find_acquire_program)
  scripts/ports.cmake:147 (include)


error: building ffmpeg:x64-osx-min1012 failed with: BUILD_FAILED
@JoergAtGithub
Copy link
Member

LGTM! Thank you!

@JoergAtGithub JoergAtGithub merged commit 8cd543b into mixxxdj:2.4 Nov 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants