Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove waypoint position slider steps and add text field for all sliders #819

Closed
Ramtech59Sensei opened this issue Oct 6, 2024 · 1 comment · Fixed by #846
Closed

Remove waypoint position slider steps and add text field for all sliders #819

Ramtech59Sensei opened this issue Oct 6, 2024 · 1 comment · Fixed by #846
Labels
enhancement New feature or request GUI Changes to the PathPlanner GUI
Milestone

Comments

@Ramtech59Sensei
Copy link

Ramtech59Sensei commented Oct 6, 2024

Describe the bug
Event marker slider, Rotation Target Slider, Point Towards Zone slider , Constrain Zone Slider
Every slider max a value of 2 even to is represented in the Graphic correctly, it make hard to mach with the time in paths.
The step in slider is fix to 0.05. For small paths the precision is acceptable but in long paths the step is to big. It is not possible to place the indicator in an specific place (the displacement between steps is to big ) .

note
In new path with only 2 point it stay a 1 but the behavior is the same, with 3 point it jump to 2 and so on.

Expected behavior
All position slider can be represented 0% to 100% then the position precision can be a 0.05 or use the same time base in the path
with exception of "Point Towards Zone slider" and "Rotation Target" that should stay away from "Start State" and "End State"

Screenshots
test2

Additional context
I think using the path time is the best approach but make it hard to maintain since every time you change the path length the time change , the next best will be % use 0-100 with a step of 0.05 or different.
I like that "Point Towards Zone slider" is not allow to place a "Point Towards Zone" on path start and path end , the slider start at 0.05 and end at 1.95, should not be like than for "Rotation Target" since "Start State" and "End State" are always on?
When you place a rotation target on path start or path end it get ignored.

@Ramtech59Sensei Ramtech59Sensei added the bug Something isn't working label Oct 6, 2024
@Ramtech59Sensei Ramtech59Sensei changed the title Posistion slider max out at 2 Position slider max out at 2 Oct 6, 2024
@Ramtech59Sensei
Copy link
Author

After review and reproducing my own Bug report , I think you only need to change the step to make it more precise and correct "Rotation Target" to be match "Point Towards Zone slider"

@Ramtech59Sensei Ramtech59Sensei changed the title Position slider max out at 2 Position slider need more precision Oct 6, 2024
@mjansen4857 mjansen4857 changed the title Position slider need more precision Remove waypoint position slider steps and add text field for all sliders Oct 6, 2024
@mjansen4857 mjansen4857 added enhancement New feature or request GUI Changes to the PathPlanner GUI and removed bug Something isn't working labels Oct 6, 2024
@mjansen4857 mjansen4857 added this to the 2025 Beta 2 milestone Oct 6, 2024
@mjansen4857 mjansen4857 linked a pull request Oct 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI Changes to the PathPlanner GUI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants