Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to create a copy constructor #74

Closed
wants to merge 5 commits into from

Conversation

c-mansfield
Copy link

This PR adds the ability for a copy constructor as seen below.

` public static final class RecordABuilder {
private String fieldOne;
private String fieldTwo;

    private RecordABuilder() {
    }

    private RecordABuilder(RecordA recordA) {
        this.fieldOne = recordA.fieldOne();
        this.fieldTwo = recordA.fieldTwo();
    }
 ...

}`

Currently an optional feature through the ui popup.

@c-mansfield c-mansfield marked this pull request as ready for review November 10, 2023 14:57
@c-mansfield c-mansfield marked this pull request as draft December 4, 2023 14:18
@c-mansfield c-mansfield marked this pull request as ready for review February 11, 2024 20:30
@c-mansfield
Copy link
Author

Hey @mjedynak, when you get a minute could you please take a look at this PR 😃

@mjedynak
Copy link
Owner

hi @c-mansfield, thanks for the PR, I'll try to look at it shortly.

@mjedynak
Copy link
Owner

mjedynak commented Feb 17, 2024

I cherry picked your commits as there were some issues (generated code was not compiling in case of using single field and copy constructor) that I fixed myself.
Released in 1.4.0.

@mjedynak mjedynak closed this Feb 17, 2024
@c-mansfield c-mansfield deleted the copy-constructor branch February 17, 2024 14:53
@c-mansfield
Copy link
Author

Thank you @mjedynak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants