Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI error #273

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Fix CI error #273

merged 1 commit into from
Aug 15, 2024

Conversation

jkawamoto
Copy link
Contributor

This PR fixes the CI error https://github.com/mjpost/sacrebleu/actions/runs/10151812795.

The pip command now matches the one used in the other CI script:

- name: Build
run: |
pip install build
python -m build .

@martinpopel martinpopel merged commit 0f35101 into mjpost:master Aug 15, 2024
19 checks passed
@martinpopel
Copy link
Collaborator

Thanks.
I guess alternative solutions would be

  • add build = ["build"] to pyproject.toml's project.optional-dependencies, where currently we have only dev, ja and ko.
    This way we could use pip install .[build] (both in check-build.yml and python-publish.yml), but I don't see much benefit in it.
  • We could add the build package to the dev optional-dependencies and use pip install .[dev] instead of pip install .[build], but this seems an overkill as the other dev depenencies are not needed for the very build.
    So in the end, I prefer your simple solution.

@jkawamoto
Copy link
Contributor Author

Agreed. If we need other dependencies required to build this package or need to fix the version of the build library, perhaps it is time to consider adding build optional dependency.

By the way, would you mind releasing v2.4.3?

@martinpopel
Copy link
Collaborator

I am one of the PyPI maintainers of sacrebleu (and I think I could upload there a release manually, although I haven't done so yet), but I don't have permissions for https://pypi.org/manage/project/sacrebleu/settings/publishing/ (unlike for another PyPI project I own), so I think I cannot configure my OpenID for sacrebleu PyPI. So @mjpost needs to release v2.4.3.

@jkawamoto
Copy link
Contributor Author

Got it. Thank you for your explanation.

@mjpost
Copy link
Owner

mjpost commented Aug 17, 2024

Hi @martinpopel, you should have permissions to publish packages. But didn't we automate this recently, so that it should be published automatically from tags?

@mjpost
Copy link
Owner

mjpost commented Aug 17, 2024

It looks like me adding the tag and pushing caused a version to be published: https://pypi.org/project/sacrebleu/#history

I wonder if what we need is to add Martin's (and also Ozan's?) ID to this check?

@martinpopel
Copy link
Collaborator

I thought, I need to first configure OpenID at https://pypi.org/manage/project/sacrebleu/settings/publishing/, but it says "You don't have permission to view this page".
v2.4.3 is now published. Next time, I can try first adding a tag.

@jkawamoto
Copy link
Contributor Author

Thank you for releasing v2.4.3.

To my understanding, this line only prevents fork repositories from running the CI script:

if: ${{ github.repository_owner == 'mjpost' }}

There might be rules to restrict who can make tags in Settings > Tags.

@jkawamoto jkawamoto deleted the pip-install-build branch August 17, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants