-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI error #273
Fix CI error #273
Conversation
Thanks.
|
Agreed. If we need other dependencies required to build this package or need to fix the version of the By the way, would you mind releasing v2.4.3? |
I am one of the PyPI maintainers of sacrebleu (and I think I could upload there a release manually, although I haven't done so yet), but I don't have permissions for https://pypi.org/manage/project/sacrebleu/settings/publishing/ (unlike for another PyPI project I own), so I think I cannot configure my OpenID for sacrebleu PyPI. So @mjpost needs to release v2.4.3. |
Got it. Thank you for your explanation. |
Hi @martinpopel, you should have permissions to publish packages. But didn't we automate this recently, so that it should be published automatically from tags? |
It looks like me adding the tag and pushing caused a version to be published: https://pypi.org/project/sacrebleu/#history I wonder if what we need is to add Martin's (and also Ozan's?) ID to this check? |
I thought, I need to first configure OpenID at https://pypi.org/manage/project/sacrebleu/settings/publishing/, but it says "You don't have permission to view this page". |
Thank you for releasing v2.4.3. To my understanding, this line only prevents fork repositories from running the CI script:
There might be rules to restrict who can make tags in Settings > Tags. |
This PR fixes the CI error https://github.com/mjpost/sacrebleu/actions/runs/10151812795.
The pip command now matches the one used in the other CI script:
sacrebleu/.github/workflows/check-build.yml
Lines 56 to 59 in 5af5a3a