sysoptions.h: move keepalive string above ident #302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenWrt package removes Dropbear version from ident string. Until now, that was done with sed, instead of a patch. I'm trying to change that to a patch and I noticed that the version string is defined only 3 lines above the ident string. A normal patch would include that line. Any version change would invalidate the patch. I moved the keepalive string just above the ident string, as these are somewhat related. That will keep the version string outside the patch. Signed-off-by: Marius Dinu <m95d+git@psihoexpert.ro>
|
I think I'd prefer something like /* IDENT_VERSION is the optional part after "SSH-2.0-dropbear". Refer to RFC4253 for requirements */
#ifndef IDENT_VERSION_PART
#define IDENT_VERSION_PART "_" DROPBEAR_VERSION
#endif
#define LOCAL_IDENT "SSH-2.0-dropbear" IDENT_VERSION_PARTThen you could put |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenWrt package removes Dropbear version from ident string. Until now, that was done with sed, instead of a patch. I'm trying to change that to a patch.
I noticed that the version string is defined only 3 lines above the ident string. A normal patch would include the version line. Any version change would invalidate the patch.
To keep the version string outside the patch. I moved the keepalive string just above the ident string, as these are somewhat related.
If you don't like this PR, an alternative would be to add a comment-description of the ident string. That would also push the the version string outside the patch.
Thanks.