Revert "adjust gem post install hook to allow updating the default gem" #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 006fb25.
|
@ccutrer I would still like to make jar-dependencies upgradable without introducing a hard dependency break! Perhaps something could be done to check JRuby's version and fall back on older logic? I needed to revert this in order to release a fix for jruby/jruby#7059. I'm also hoping that your "modernization" patch is benign and could safely be released in 0.4.3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 006fb25.
While the patch provided by @ccutrer did make jar-dependencies upgradable, it also caused a hard break in compatibility with earlier JRuby versions and had to eventually be reversed (jar-dependencies 0.4.2 yanked, changes to JRuby reverted). This closes the loop and reverts the changes in jar-dependencies, so we can go forward with compatible changes for now.