Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LlaVA in MLX #461
LlaVA in MLX #461
Changes from 26 commits
4d964bd
0e2a054
6e4a7ee
ed9d376
b83b1e5
6e23847
bb5b898
95f9df1
a1c6fe6
cec0639
4dd8bca
c4ea94f
b9aeade
d8f7b89
7fb1a39
371a807
449f7d0
a1cab2b
8e6b2f5
823411c
6bc06c8
feec5ec
d76fd40
49f928a
c2b8463
25a65cf
c2c9411
8301c43
5c8f67d
cd77bcf
b39c251
935ebb5
683b7c4
b37891d
7ace6ea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the implementation is copied from mlx-lm's llama, with only updates made to the forward pass to allow for directly passing inputs_embeds for the initial prompt evaluation.