Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #3

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Refactor #3

wants to merge 18 commits into from

Conversation

gagoar
Copy link

@gagoar gagoar commented Nov 11, 2021

Description

This PR does multiple things:

  • adds TS support
  • add tests (91% at the moment)
  • adds basic infra

TODO:

  • re org the filesystem
  • remove old code under _old/
  • clean up tests
  • merge some functionality into files
  • add Readme
  • Make interface so the encoder is already built in inside the decode and encode functionality

@gagoar gagoar requested review from mlacosta November 11, 2021 21:17
@@ -1,33 +1,46 @@
# Huffman-URL-Compressor-for-Nodejs
## Author: Mariano L. Acosta
<p align="center">
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this readme should be adjusted to your repo. @mlacosta

@@ -0,0 +1,3 @@
export * from './decodeContent'
export * from './encodeContent';
export * from './createEncoder';
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export * from './createEncoder';
export * from './createEncoder';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants