Add Prometheus metrics for DarkBlue Service #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jayamala17
commented
May 1, 2024
•
jayamala17
commented
- Added Prometheus pushgateway used for monitoring batch or cron jobs.
- Through the gateway url endpoint the metrics are pushed to prometheus
- Added metrics for job duration, last job run. and metrics regards to success and failure count on each job run.
|
Hi @jayamala17, could you resolve the conflicts, improve the title, and add a short description? |
jayamala17
changed the title
ssciolla
reviewed
May 9, 2024
ssciolla
reviewed
May 13, 2024
ssciolla
reviewed
May 14, 2024
ssciolla
reviewed
May 16, 2024
ssciolla
reviewed
May 16, 2024
|
I got this working on my local machine, looks cool! 🙂 |
|
@jayamala17, FYI, I started experimenting with the Mock stuff, found a couple other things worth considering. I'm going to open a PR with the changes so it's easier to talk about. We can discuss tomorrow. |
ssciolla
reviewed
May 17, 2024
ssciolla
approved these changes
May 17, 2024
| @@ -35,7 +36,7 @@ def initialize(config) | |||
| type: config.aptrust.remote.type, | |||
| settings: config.aptrust.remote.settings | |||
| ), | |||
| status_event_repo: StatusEventRepository::StatusEventRepositoryFactory.for(use_db: DB), | |||
| status_event_repo: S.status_event_repo, | |||
There was a problem hiding this comment.
Let's not do this now, but I'd like to get to a place where we only use S in the top-level scope, meaning we'd have to add a new constructor parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.