solr document handles non loc_id subject ids

mlibrary · May 21, 2024 · 32c3b5a · 32c3b5a
1 parent fd1dac0
commit 32c3b5a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/lib/authority_browse/solr_document/authority_graph.rb b/lib/authority_browse/solr_document/authority_graph.rb
@@ -31,11 +31,11 @@ def term
         first[:label]
       end
 
-      # Library of Congress ID
+      # Library of Congress ID if the id is a valid one
       #
       # @return [String]
       def loc_id
-        first[:id]
+        first[:id] if first[:id].match?("loc.gov")
       end
 
       # @return [Integer]

diff --git a/spec/authority_browse/names_spec.rb b/spec/authority_browse/names_spec.rb
@@ -62,7 +62,6 @@
       expect(file_contents).to eq([
         {
           id: "first\u001fname",
-          loc_id: "id1",
           browse_field: "name",
           term: "First",
           count: 1,
@@ -71,15 +70,13 @@
         }.to_json + "\n",
         {
           id: "second\u001fname",
-          loc_id: "id2",
           browse_field: "name",
           term: "Second",
           count: 2,
           date_of_index: Date.today.strftime("%Y-%m-%d") + "T00:00:00Z"
         }.to_json + "\n",
         {
           id: "third\u001fname",
-          loc_id: "id3",
           browse_field: "name",
           term: "Third",
           count: 3,

diff --git a/spec/authority_browse/solr_document/subjects_spec.rb b/spec/authority_browse/solr_document/subjects_spec.rb
@@ -72,9 +72,13 @@
     end
   end
   context "#loc_id" do
-    it "returns the loc_id" do
+    it "returns the loc_id when the id is a loc id" do
       expect(subject.loc_id).to eq(counterpoint_id)
     end
+    it "returns nil when it's not" do
+      @subject[0][:id] = "9912351598"
+      expect(subject.loc_id).to be_nil
+    end
   end
   context "#term" do
     it "has the expected term" do

diff --git a/spec/authority_browse/subjects_spec.rb b/spec/authority_browse/subjects_spec.rb
@@ -78,7 +78,6 @@
       expect(file_contents).to eq([
         {
           id: "first\u001fsubject",
-          loc_id: "id1",
           browse_field: "subject",
           term: "First",
           count: 1,
@@ -88,15 +87,13 @@
         }.to_json + "\n",
         {
           id: "second\u001fsubject",
-          loc_id: "id2",
           browse_field: "subject",
           term: "Second",
           count: 2,
           date_of_index: Date.today.strftime("%Y-%m-%d") + "T00:00:00Z"
         }.to_json + "\n",
         {
           id: "third\u001fsubject",
-          loc_id: "id3",
           browse_field: "subject",
           term: "Third",
           count: 3,