Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we should maybe check in learner / autotest that weights_learner influences the fit / the predictions of the learner #1117

Open
berndbischl opened this issue Aug 23, 2024 · 3 comments
Open

we should maybe check in learner / autotest that weights_learner influences the fit / the predictions of the learner #1117

berndbischl opened this issue Aug 23, 2024 · 3 comments
Labels
Weights

Comments

@berndbischl
Copy link
Sponsor Member

we do have simple tests for weights_measure and weights_resampling for this
@berndbischl
Copy link
Sponsor Member Author

we could actually check this also more generically for all measures and all resamplings.... at least for resamplings I am fine with the current state

@berndbischl
Copy link
Sponsor Member Author

we could also check that weights[i] = 0 effectively removes obs

@berndbischl
Copy link
Sponsor Member Author

we could also for measures really test that the final performance value is exactly as expected in terms of the formula

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Weights
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@berndbischl @be-marc