Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark_grid should not allow learners with the same ID #1165

Closed
berndbischl opened this issue Sep 4, 2024 · 1 comment
Closed

benchmark_grid should not allow learners with the same ID #1165

berndbischl opened this issue Sep 4, 2024 · 1 comment
Assignees
@be-marc
Labels
Type: Enhancement

Comments

@berndbischl
Copy link
Member

berndbischl commented Sep 4, 2024 •
edited
Loading 

tt = tsk("iris")
lrn1 = lrn("classif.rpart", id = "foo")
lrn2 = lrn("classif.rpart", id = "foo")

xs = list(lrn1, lrn2)

bg = benchmark_grid(learners = xs, tasks = tt, resampling = rsmp("holdout"))
br = benchmark(bg)

this should probably be illegal. also then add a test.
@be-marc
Copy link
Member

be-marc commented Nov 1, 2024

#1195

@be-marc be-marc closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@be-marc be-marc

Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@berndbischl @be-marc