From 1383942d5f1ee4c05bb6caa23e4a2c4dc921c877 Mon Sep 17 00:00:00 2001 From: Mario Mainz Date: Thu, 24 Aug 2023 10:11:13 +0200 Subject: [PATCH 1/3] Add coveralls.io --- .github/workflows/ci.yml | 3 +++ Gemfile.lock | 10 ++++++++++ package-lock.json | 1 + spec/spec_helper.rb | 6 ++++++ valued.gemspec | 8 +++++--- 5 files changed, 25 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7a3c025..1866c40 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -33,3 +33,6 @@ jobs: - name: Run tests ⚙️ run: bundle exec rake + + - name: Coverage 📊 + uses: coverallsapp/github-action@v2 diff --git a/Gemfile.lock b/Gemfile.lock index 4f53807..c59006a 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -8,6 +8,7 @@ GEM specs: ast (2.4.0) diff-lcs (1.3) + docile (1.4.0) jaro_winkler (1.5.4) parallel (1.19.1) parser (2.7.0.4) @@ -39,6 +40,13 @@ GEM rubocop-rspec (1.38.1) rubocop (>= 0.68.1) ruby-progressbar (1.10.1) + simplecov (0.22.0) + docile (~> 1.1) + simplecov-html (~> 0.11) + simplecov_json_formatter (~> 0.1) + simplecov-html (0.12.3) + simplecov-lcov (0.8.0) + simplecov_json_formatter (0.1.4) unicode-display_width (1.6.1) PLATFORMS @@ -50,6 +58,8 @@ DEPENDENCIES rspec (~> 3.0) rubocop (~> 0.80) rubocop-rspec (~> 1.38) + simplecov (~> 0.22) + simplecov-lcov (~> 0.8) valued! BUNDLED WITH diff --git a/package-lock.json b/package-lock.json index c3d74cb..0cb7308 100644 --- a/package-lock.json +++ b/package-lock.json @@ -4,6 +4,7 @@ "requires": true, "packages": { "": { + "name": "valued", "devDependencies": { "@prettier/plugin-ruby": "^1.6.1", "prettier": "^2.3.2" diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 09cfb30..4d96c27 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,3 +1,9 @@ +require 'simplecov' +require 'simplecov-lcov' +SimpleCov::Formatter::LcovFormatter.config.report_with_single_file = true +SimpleCov.formatter = SimpleCov::Formatter::LcovFormatter +SimpleCov.start + require 'bundler/setup' require 'valued' require 'valued/shared_examples/valued_shared_examples' diff --git a/valued.gemspec b/valued.gemspec index 36d8903..f8e3913 100644 --- a/valued.gemspec +++ b/valued.gemspec @@ -17,10 +17,10 @@ Gem::Specification.new do |spec| spec.files = Dir.chdir(File.expand_path('..', __FILE__)) do - `git ls-files -z`.split("\x0").reject do |f| - f.match(%r{^(test|spec|features)/}) + `git ls-files -z`.split("\x0").reject do |f| + f.match(%r{^(test|spec|features)/}) + end end - end spec.bindir = 'exe' spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } @@ -31,4 +31,6 @@ Gem::Specification.new do |spec| spec.add_development_dependency 'rspec', '~> 3.0' spec.add_development_dependency 'rubocop', '~> 0.80' spec.add_development_dependency 'rubocop-rspec', '~> 1.38' + spec.add_development_dependency 'simplecov', '~> 0.22' + spec.add_development_dependency 'simplecov-lcov', '~> 0.8' end From ca5ef407a28310ba464375d5cbb5ed0af106679d Mon Sep 17 00:00:00 2001 From: Mario Mainz Date: Thu, 24 Aug 2023 10:19:49 +0200 Subject: [PATCH 2/3] Filter out spec dir for coverage --- spec/spec_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 4d96c27..f56924d 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -2,7 +2,7 @@ require 'simplecov-lcov' SimpleCov::Formatter::LcovFormatter.config.report_with_single_file = true SimpleCov.formatter = SimpleCov::Formatter::LcovFormatter -SimpleCov.start +SimpleCov.start { add_filter '/spec/' } require 'bundler/setup' require 'valued' From ef27a7fcd13438c821570e1e5faffffd9beff4e2 Mon Sep 17 00:00:00 2001 From: Mario Mainz Date: Thu, 24 Aug 2023 10:19:59 +0200 Subject: [PATCH 3/3] Add coverage badge to README.md --- README.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 5289cda..7b952ae 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -[![Build Status](https://travis-ci.org/mmainz/valued.svg?branch=master)](https://travis-ci.org/mmainz/valued) +[![Coverage Status](https://coveralls.io/repos/github/mmainz/valued/badge.svg?branch=master)](https://coveralls.io/github/mmainz/valued?branch=master) # Valued @@ -82,7 +82,8 @@ p quantity => # ``` -You can create a duplicate of your object with updated attributes by using `update`. +You can create a duplicate of your object with updated attributes by using +`update`. ```ruby quantity = Quantity.new(unit: 'm', amount: 2) @@ -93,7 +94,8 @@ p updated_quantity => # ``` -If you really need a mutable object, just use `Valued::Mutable` instead of `Valued`. +If you really need a mutable object, just use `Valued::Mutable` instead of +`Valued`. ```ruby require 'valued'