Add wrapping errors #517
Merged
Add wrapping errors #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before there was one page about error handling. Now there are three. A simple page (the first part of the existing page). Then a new page about wrapping errors. And the third page is the second half of the existing page (custom errors).
guettli
force-pushed
the
add-wrapping-errors
branch
from
65b03ae
to
62da17f
Compare
eliben
reviewed
Mar 20, 2024
| "math/rand/v2" | ||
| ) | ||
|
|
||
| // A "sentinel error" has usualy the prefix "Err" |
There was a problem hiding this comment.
This needs a bit more explanation of what "sentinel error" is - as a stylistic convention
| return ErrOutOfTea | ||
| } | ||
| if rand.Int32N(7) == 0 { | ||
| // You can wrap a sentinel error with %w |
| if err != nil { | ||
| // By using several if-statements we can handle | ||
| // different sentinel errors. | ||
| // A switch statement is not applicable here. |
There was a problem hiding this comment.
This doesn't explain what Is does and how it's different from using a type switch, and why a type switch is not applicable.
There was a problem hiding this comment.
I elaborated the comment.
eliben
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add sentinel errors and wrapping errors.
Fixes #334