Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use seek enums and show other seek methods #524

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Use seek enums and show other seek methods #524

merged 2 commits into from
Apr 29, 2024

Conversation

kauppie
Copy link
Contributor

@kauppie kauppie commented Apr 26, 2024

  • Converted io.Seek(0, 0) calls to io.Seek(0, io.SeekStart) to reduce the use of magic values.
  • Added example of using io.Seek(x, io.SeekCurrent) and io.Seek(x, io.SeekEnd).

eliben
eliben approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@eliben eliben merged commit baadeda into mmcgrana:master Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliben eliben eliben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kauppie @eliben