Remove unreachable code from enums example #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliben
approved these changes
Jul 3, 2024
My pleasure! Thank YOU for the lovely refresher course after not having looked at any Go for a month! 😁 |
|
woops, fat fingered the mouse on that early close before merge. Apologies! |
No worries, it's merged now. Note that it may take a few days to show up on the published website, since the upload is done manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After confirming I did not misunderstand how switch default and panic works, I realized there was some unreachable code in the example that may confuse new learners. Go LSP confirms.