Merge pull request #14 from moaxaca/develop

Release/v1.1.5
moaxaca · Jan 14, 2019 · e9ca5d4 · e9ca5d4
2 parents e02adc7 + c9bbb0e
commit e9ca5d4
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "private": false,
-  "version": "1.1.4",
+  "version": "1.1.5",
   "name": "async-redis",
   "keywords": [
     "redis",

diff --git a/src/index.js b/src/index.js
@@ -11,8 +11,13 @@ const AsyncRedis = function (args) {
 
 AsyncRedis.createClient = (...args) => new AsyncRedis(args);
 
+// this is the set of commands to NOT promisify
+const commandsToSkipSet = new Set(['multi']);
+// this is the set of commands to promisify
+const commandSet = new Set(commands.filter(c => !commandsToSkipSet.has(c)));
+
 AsyncRedis.decorate = redisClient => objectDecorator(redisClient, (name, method) => {
-  if (commands.includes(name)) {
+  if (commandSet.has(name)) {
     return (...args) => new Promise((resolve, reject) => {
       args.push((error, ...results) => {
         if (error) {

diff --git a/test/integration/commands/common.spec.js b/test/integration/commands/common.spec.js
@@ -54,4 +54,12 @@ describe('Commands - Common', function () {
       assert.isRejected(promise, Error);
     });
   });
+
+  describe('test multi not a promise', function () {
+    it('should be not equal', async () => {
+      let notAPromise = redisClient.multi();
+      console.log(notAPromise);
+      assert.notEqual(Promise.resolve(notAPromise), notAPromise);
+    });
+  });
 });