only creating temp file if a thumbnail has been created

mobilejazz · Jan 29, 2015 · 85b870b · 85b870b
1 parent 89e7665
commit 85b870b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/library/src/main/java/com/mobilejazz/coltrane/library/utils/thumbnail/Thumbnail.java b/library/src/main/java/com/mobilejazz/coltrane/library/utils/thumbnail/Thumbnail.java
@@ -84,6 +84,7 @@ public static Bitmap fromPDF(final ParcelFileDescriptor input, final Point sizeH
 
         } catch (Exception e) {
             // something went wrong:
+            e.printStackTrace();
             return null;
         } finally {
             is.close();

diff --git a/...esystem/src/main/java/com/mobilejazz/coltrane/provider/filesystem/FileSystemProvider.java b/...esystem/src/main/java/com/mobilejazz/coltrane/provider/filesystem/FileSystemProvider.java
@@ -118,11 +118,11 @@ protected String getDocumentThumbnailId(final String documentId, final Point siz
     protected File getDocumentThumbnailFile(final String documentId, final Point sizeHint) throws FileNotFoundException {
         FileOutputStream out = null;
         try {
-            File cacheDir = getContext().getCacheDir();
-            File thumbnail = File.createTempFile(getDocumentThumbnailId(documentId, sizeHint), "", cacheDir);
             String mimeType = mAccessor.getMimeType(new File(documentId));
             Bitmap bitmap = Thumbnail.fromFile(documentId, sizeHint, mimeType);
             if (bitmap != null) {
+                File cacheDir = getContext().getCacheDir();
+                File thumbnail = File.createTempFile(getDocumentThumbnailId(documentId, sizeHint), "", cacheDir);
                 out = new FileOutputStream(thumbnail);
                 bitmap.compress(Bitmap.CompressFormat.PNG, 90, out);
                 return thumbnail;