Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add break timer #163

Closed
wants to merge 31 commits into from
Closed

Conversation

dbartholomae
Copy link
Contributor

I've written a first implementation based on this proposal I added in #119. It would be helpful for me to have on Monday, but if you need more time, I will be able to live without it a bit longer ;)
I had to make some additional smaller clean ups around the the Timer subscription and usage of currentTime from state to be able to use the Timer subscription for multiple timers.

@dbartholomae
Copy link
Contributor Author

By the way, if it helps to reduce the effort on your end, I'm happy to have a call and discuss the changes :)

@mrozbarry mrozbarry linked an issue Nov 13, 2020 that may be closed by this pull request
@mrozbarry
Copy link
Collaborator

I'm really on the fence with this feature. The code looks good, so I'm not concerned with that, but I'd want feedback on how mobs currently manage their breaks. For reference, I have at least 10 teams at work that manage breaks on their own while still using mobtime, so I'm curious what the value add is.

@mrozbarry
Copy link
Collaborator

Also, sorry it took me a while to get back to you on this!

@dbartholomae
Copy link
Contributor Author

I'm currently running two mobs with this version of the timer (hosted at https://mobtime.herokuapp.com/ ). I know that others asked me for that version as well, but I didn't yet get feedback from them whether they actually use it.
The main reasons for us to use the integrated break timers are:

  1. Having only one tool to set up and look at as a mob instead of having to sync on multiple tools.
  2. Being reminded of breaks less intrusively as the timer just stops you from starting the next round, but doesn't interrupt your current one (which often lead us to "first finish what we are up to" and then forget the break all together)

@adamkasztenny
Copy link
Contributor

adamkasztenny commented Jan 29, 2021

Our mob would really appreciate this feature as well. Our concerns are the same as @dbartholomae 's; managing two timers is clunky (especially when the break timer is not shared), and being forced to take breaks is always nice.

const initialState = {
breakTimerStartedAt: new Date(),
settings: {
breaksEnabled: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, fixed

@mrozbarry
Copy link
Collaborator

So a lot has changed in the code-base since this PR. master is the base again (dev will probably be deleted in the near future), and on top of that, I am thinking of building a bot for break timers rather than a direct integration. With that in mind, I'm going to close this, but maybe there will be an opportunity in the future to revisit this.

@mrozbarry mrozbarry closed this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Break timer like mobster (http://mobster.cc/)
3 participants