WIP: Show loading indicator when waiting for data to load #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haraldreingruber is there any other work that needs to be done on this? |
|
@mrozbarry We added the initialLoadingComplete flag to the state object and created some first tests. The actual UI part is still missing... As I started a new job recently, I am afraid I won't be able to continue on that any time soon. |
|
@haraldreingruber okay, I'm working on some UI design for mobtime, so maybe we can think through what a progress bar/spinner should look like while we're at it. And no worries, congratulations on the new job! |
|
I'm going to close this for now, but if it gets into a working state, feel free to re-open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (@dbartholomae, @3ng7n33r, @dpolivaev and myself) started working on #161 during our Hacktoberfest Mob-Programming session, but were not able to finish up the improvement during the session.
I will try to continue working on that PR during next week.
@mrozbarry if you find some time it would be great if you have a quick look over the changes. Let me know if there is anything going in a unexpected direction because of us not knowing the big picture that well.