NODE_ENV

[milesje]

So I just updated to Mobx v6.X and had issues with mobx complaining about the NODE_ENV not being set.... so after some searching the only option I found that actually works was to hard code this globalThis.process = { env: { NODE_ENV: 'production' } }; in my index.html file. I can provide a test application via zip file or github repo if needed. But, it does seem a little unusual for have to set this value for a Web Application. Is there another way to get this value set that I just don't know about that would be better than hard coding it into the index.html file?

Here is a test web application to see what I'm talking about.
https://github.com/milesje/navigo-test

[mweststrate]

Depends on whether you are using MobX using a script tag or a bundler. Bundlers should take care of setting it, if you use a script tag, make sure to pick the UMD build.

…

On Wed, Jan 13, 2021 at 11:04 PM Jacob Miles ***@***.***> wrote: So I just updated to Mobx v6.X and had issues with mobx complaining about the NODE_ENV not being set.... so after some searching the only option I found that actually works was to hard code this globalThis.process = { env: { NODE_ENV: 'production' } }; in my index.html file. I can provide a test application via zip file or github repo if needed. But, it does seem a little unusual for have to set this value for a Web Application. Is there another way to get this value set that I just don't know about that would be better than hard coding it into the index.html file? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2714>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN4NBGKACMGRNBWKRKKOCDSZYRIHANCNFSM4WBRSYFA> .

[urugator]

Afaik rollup does nearly nothing without plugins except merging the sources.
@milesje #2564 (comment) could help

[milesje]

It is being imported like import { observable, action } from 'mobx' in a .ts file, but I'm not using a bundler (during development). I'm just using the TypeScript compiler to compile everything to JavaScript and then use @web/dev-server to run the output of tsc in watch mode.

Here is the 'start' script in my package.json

"start": "tsc && concurrently -k -r \"tsc --watch --preserveWatchOutput\" \"wds\"",

[danielkcz]

And where are you running that compiled code? In NodeJS?

[milesje]

In a browser

[milesje]

@FredyC And even when using rollup to bundle everything together I still get the error Uncaught ReferenceError: process is not defined

And this is running the bundled version that was output from rollup.

[milesje]

OK, I found a workaround (maybe a solution).... I can add a rollup plugin to @web/dev-server to inject the process.env.NODE_ENV, but this really seems like a hacky way of doing things. Also when bundling with rollup I also have to add this same plugin to get it to inject the process.env.NODE_ENV.

[milesje]

OK, I found a workaround (maybe a solution).... I can add a rollup plugin to @web/dev-server to inject the process.env.NODE_ENV, but this really seems like a hacky way of doing things. Also when bundling with rollup I also have to add this same plugin to get it to inject the process.env.NODE_ENV.

[mweststrate]

Rollup doesn't default to bundling modules for the web specifically. To bundle for browser consumption, you will need to use either the prebuild umd version of mobx, or use a webbundler like webpack or parcel, or indeed further configure rollup with plugins. This is further working as intended, as without this setup, bundlers wouldn't be able to pick separate versions for prod or debug. Op do 14 jan. 2021 21:38 schreef Jacob Miles <notifications@github.com>:

…

OK, I found a workaround (maybe a solution).... I can add a rollup plugin to @web/dev-server to inject the process.env.NODE_ENV, but this really seems like a hacky way of doing things. Also when bundling with rollup I also have to add this same plugin to get it to inject the process.env.NODE_ENV. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2714 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN4NBAFKRTDKQK6WL2ZQCLSZ5P5ZANCNFSM4WBRSYFA> .