Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev use module api #18

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Dev use module api #18

merged 5 commits into from
Jul 3, 2024

Conversation

mdorier
Copy link
Contributor

@mdorier mdorier commented Jul 3, 2024

No description provided.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 35.60606% with 85 lines in your changes missing coverage. Please review.

Project coverage is 79.14%. Comparing base (b84e567) to head (f7bba1b).

Files Patch % Lines
src/MargoManager.cpp 31.81% 15 Missing ⚠️
src/SSGManager.cpp 16.66% 15 Missing ⚠️
src/ProviderManager.cpp 33.33% 12 Missing ⚠️
src/ClientManager.cpp 33.33% 10 Missing ⚠️
src/ServiceHandle.cpp 9.09% 9 Missing and 1 partial ⚠️
src/Jx9Manager.cpp 14.28% 6 Missing ⚠️
src/ServiceGroupHandle.cpp 0.00% 5 Missing and 1 partial ⚠️
src/Server.cpp 0.00% 3 Missing ⚠️
src/ABTioManager.cpp 66.66% 2 Missing ⚠️
src/Client.cpp 33.33% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   75.85%   79.14%   +3.28%     
==========================================
  Files          72       64       -8     
  Lines        4990     4698     -292     
  Branches      368      317      -51     
==========================================
- Hits         3785     3718      -67     
+ Misses       1035      817     -218     
+ Partials      170      163       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdorier mdorier merged commit 8b5ce7e into main Jul 3, 2024
3 of 4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
@mdorier mdorier deleted the dev-use-module-api branch September 5, 2024 11:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant