Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Large refactoring #21

Closed
wants to merge 3 commits into from
Closed

WIP: Large refactoring #21

wants to merge 3 commits into from

Conversation

mdorier
Copy link
Contributor

@mdorier mdorier commented Aug 15, 2024

  • Removed clients, abt_io, ssg, and mona sections from configuration. Removed corresponding code paths and managers. The idea is that clients are generally not needed for dependency injection, and abt_io, ssg, and mona can be thought of as providers that just don't expose RPCs.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 72.41379% with 16 lines in your changes missing coverage. Please review.

Project coverage is 77.73%. Comparing base (3cdc484) to head (508b9a1).

Files Patch % Lines
src/DependencyFinder.cpp 65.21% 15 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   79.90%   77.73%   -2.17%     
==========================================
  Files          69       53      -16     
  Lines        5424     3935    -1489     
  Branches      339      220     -119     
==========================================
- Hits         4334     3059    -1275     
+ Misses        915      769     -146     
+ Partials      175      107      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdorier mdorier closed this Sep 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
@mdorier mdorier deleted the dev-large-refactoring branch September 5, 2024 11:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant