-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump v0.1.0 #8
base: main
Are you sure you want to change the base?
Bump v0.1.0 #8
Conversation
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (4)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 Walkthrough📝 WalkthroughWalkthroughThe pull request updates the versions of two dependencies in the Changes
Assessment against linked issues
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
I'm quite sure this will fail for now. We're having a problem with an inner dependency coming from ring-jetty-adapter. Exception java.lang.IncompatibleClassChangeError: class
org.eclipse.jetty.websocket.server.JettyWebSocketServerContainer
can not implement org.eclipse.jetty.websocket.api.WebSocketPolicy,
because it is not an interface creating this PR to see if this is a problem with my machine or the dependencies themselves. @Felipe-gsilva If the PR itself greens out, could you please make me a favor and try to run the tests on your machine? Just checkout this PR's branch and |
@J0sueTM indeed, I got the same error you got on you tests Caused by: java.lang.IncompatibleClassChangeError: class org.eclipse.jetty.websocket.server.JettyWebSocketServerContainer can not implement org.eclipse.jetty.websocket.api.WebSocketPolicy, because it is not an interface |
I created this repo to test if our lib was the problem, and turns it isn't. There is some dependency in the components repo that is crashing with the jetty-adapter lib from moclojer-foss. |
clj-rq needed to be compiled AOT (ahead of time). Updated that in v0.2.1, and it's working now. |
I removed the WIP to see the error, but looks like @J0sueTM you already fixes it, 🤔 |
what? I didn't do anything. Maybe it was a problem with the dependencies. Can you try running the tests locally and see if they run without problems? |
fixes #7
Summary by CodeRabbit
com.moclojer/moclojer
upgraded to version0.3.4
.com.moclojer/rq
upgraded to version0.2.0
.