Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump v0.1.0 #8

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Bump v0.1.0 #8

wants to merge 4 commits into from

Conversation

J0sueTM
Copy link
Member

@J0sueTM J0sueTM commented Sep 17, 2024

fixes #7

  • bumps moclojer v0.3.4
  • bumps clj-rq v0.2.0

Summary by CodeRabbit

  • Chores
    • Updated dependencies to enhance functionality and performance.
      • com.moclojer/moclojer upgraded to version 0.3.4.
      • com.moclojer/rq upgraded to version 0.2.0.

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

coderabbitai bot commented Sep 17, 2024

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (4)
  • wip
  • WIP
  • draft
  • DRAFT

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request updates the versions of two dependencies in the deps.edn file for a Clojure project. Specifically, the com.moclojer/moclojer dependency is upgraded from version 0.3.2 to 0.3.4, and the com.moclojer/rq dependency is updated from version 0.1.4 to 0.2.0. Other dependencies remain unchanged. These updates are part of a routine maintenance effort to ensure compatibility with the latest library versions.

Changes

Files Change Summary
deps.edn Updated com.moclojer/moclojer from 0.3.2 to 0.3.4 and com.moclojer/rq from 0.1.4 to 0.2.0.

Assessment against linked issues

Objective Addressed Explanation
Update projects dependent on recently project releases (#7)

🐰 In the garden, changes bloom,
New versions chase away the gloom.
With moclojer's leap and rq's flight,
Our project shines, oh what a sight!
Dependencies fresh, like morning dew,
Hop along, there's much to do! 🌼


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@J0sueTM
Copy link
Member Author

J0sueTM commented Sep 17, 2024

I'm quite sure this will fail for now. We're having a problem with an inner dependency coming from ring-jetty-adapter.

Exception java.lang.IncompatibleClassChangeError: class
   org.eclipse.jetty.websocket.server.JettyWebSocketServerContainer
   can not implement org.eclipse.jetty.websocket.api.WebSocketPolicy,
   because it is not an interface

creating this PR to see if this is a problem with my machine or the dependencies themselves.

@Felipe-gsilva If the PR itself greens out, could you please make me a favor and try to run the tests on your machine?

Just checkout this PR's branch and clj -M:dev:test.

@J0sueTM J0sueTM changed the title Bump v0.1.0 WIP: Bump v0.1.0 Sep 17, 2024
@J0sueTM J0sueTM added the help wanted Extra attention is needed label Sep 17, 2024
@Felipe-gsilva
Copy link

@J0sueTM indeed, I got the same error you got on you tests

Caused by: java.lang.IncompatibleClassChangeError: class org.eclipse.jetty.websocket.server.JettyWebSocketServerContainer can not implement org.eclipse.jetty.websocket.api.WebSocketPolicy, because it is not an interface

@J0sueTM
Copy link
Member Author

J0sueTM commented Sep 18, 2024

I created this repo to test if our lib was the problem, and turns it isn't. There is some dependency in the components repo that is crashing with the jetty-adapter lib from moclojer-foss.

@J0sueTM
Copy link
Member Author

J0sueTM commented Sep 20, 2024

clj-rq needed to be compiled AOT (ahead of time). Updated that in v0.2.1, and it's working now.

@matheusfrancisco matheusfrancisco changed the title WIP: Bump v0.1.0 Bump v0.1.0 Oct 31, 2024
@matheusfrancisco
Copy link
Member

matheusfrancisco commented Oct 31, 2024

I removed the WIP to see the error, but looks like @J0sueTM you already fixes it, 🤔

@J0sueTM
Copy link
Member Author

J0sueTM commented Oct 31, 2024

what? I didn't do anything. Maybe it was a problem with the dependencies. Can you try running the tests locally and see if they run without problems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update projects dependent on recently project releases
4 participants