Add harnesses for safety of primitive conversions #233
Conversation
ShoyuVanilla
force-pushed
the
challenge-14
branch
4 times, most recently
from
3d9c94a to
140887c
Compare
ShoyuVanilla
force-pushed
the
challenge-14
branch
from
140887c to
26512c1
Compare
ShoyuVanilla
force-pushed
the
challenge-14
branch
from
ad404e0 to
b33a833
Compare
ShoyuVanilla
force-pushed
the
challenge-14
branch
4 times, most recently
from
0bf5fd7 to
5ebcf38
Compare
ShoyuVanilla
force-pushed
the
challenge-14
branch
from
5ebcf38 to
8ebf05f
Compare
| generate_float_to_int_harness!(f16 => u8, check_u8_from_f16_unchecked); | ||
| generate_float_to_int_harness!(f16 => u16, check_u16_from_f16_unchecked); | ||
| generate_float_to_int_harness!(f16 => u32, check_u32_from_f16_unchecked); | ||
| generate_float_to_int_harness!(f16 => u64, check_u64_from_f16_unchecked); | ||
| generate_float_to_int_harness!(f16 => u128, check_u128_from_f16_unchecked); | ||
| generate_float_to_int_harness!(f16 => usize, check_usize_from_f16_unchecked); |
There was a problem hiding this comment.
Wouldn't it be possible to use a macro to generate all those generators? As is, it's very hard to tell whether any combinations have possibly been forgotten.
There was a problem hiding this comment.
I wish I could do so, but I think that might require extra proc macro crate to generate all those check_a_from_b_... identifiers as MBEs cannot generate identifiers.
There might be some possible alternatives;
- Make a huge, single macro that requires all identifiers like some kind of a table. This would still be verbose, but might prevent mistakes like forgotting something
- Use same identifier for same kind of harness, but segregate them into different namespaces, like
verify_from_f16::to_u32::check_float_to_int_unchecked. But this way, we will have multiple harnesses with same names
Do you have some recommendations?
There was a problem hiding this comment.
Indeed, you cannot generate identifiers with regular macros. I think your second option sounds reasonable to me. It is similar to what we've done here.
I think you might be able to do generate the namespace for the from type, and the harness using the to type.
Towards #220
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.