-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add harnesses for all functions in Alignment #42
Conversation
In model-checking#33 a contract was added to `Alignment::new_unchecked`, but its verification was only implicit through `Layout`, and may be affected by future changes to the contract that was added to `Layout`. This commit remedies this by adding a separate harness just for `Alignment`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but did you try the safety_constraint
?
No, because I can't get |
Please see my reply above |
Why did you revert the |
I thought it was causing the compile errors, but then I realised it’s #49 that’s needed. Will continue on this once Kani and this repo are back in a working state. |
Now successfully using |
In #33 a contract was added to
Alignment::new_unchecked
, but its verification was only implicit throughLayout
, and may be affected by future changes to the contract that was added toLayout
. This commit remedies this by adding a separate harness just forAlignment
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.