You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify pr workflow to require 2 approvals on all PR's
Call Outs
All PR's will need 2 approvals from the commitee for this check to pass.
A more intelligent approach is on the way, but till then all PR's will need 2 approvals.
This is done to prevent sneak attacks where someone gets approval for non-std related changes, and after approval, they make changes to the std files.
You could comment this out instead of deleting if you think you'll iterate on it later, but up to you.
What do you mean by "this" in "comment this out"?
If youre talking about the closed PR, then I prefer to start afresh. I need a fresh testing ground for the checks.
You could comment this out instead of deleting if you think you'll iterate on it later, but up to you.
What do you mean by "this" in "comment this out"? If youre talking about the closed PR, then I prefer to start afresh. I need a fresh testing ground for the checks.
I meant comment out the sections of the files you deleted in this PR.
You could comment this out instead of deleting if you think you'll iterate on it later, but up to you.
What do you mean by "this" in "comment this out"? If youre talking about the closed PR, then I prefer to start afresh. I need a fresh testing ground for the checks.
I meant comment out the sections of the files you deleted in this PR.
Ah sorry. I think I prefer to delete, I can always refer to this PR in case I want to come back to these diffs, and I stashed these changes in my fork too. No reason to keep this branch full of redundant comments.
…ng#74)
Simplify pr workflow to require 2 approvals on all PR's
## Call Outs
All PR's will need 2 approvals from the commitee for this check to pass.
A more intelligent approach is on the way, but till then all PR's will
need 2 approvals.
This is done to prevent sneak attacks where someone gets approval for
non-std related changes, and after approval, they make changes to the
std files.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify pr workflow to require 2 approvals on all PR's
Call Outs
All PR's will need 2 approvals from the commitee for this check to pass.
A more intelligent approach is on the way, but till then all PR's will need 2 approvals.
This is done to prevent sneak attacks where someone gets approval for non-std related changes, and after approval, they make changes to the std files.
Testing
Failed check after just 1 approver :- https://github.com/jaisnan/rust-dev/actions/runs/10583003063
Successful check after 2nd approver :- https://github.com/jaisnan/rust-dev/actions/runs/10583018556
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.