Restore init for clocked discretized. #3577
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansOlsson
added
bug
henrikt-ma
reviewed
Sep 26, 2024
| @@ -1400,13 +1400,13 @@ \subsection{Inferencing of solverMethod}\label{inferencing-of-solvermethod} | |||
|
|
|||
| \section{Initialization of Clocked Partitions}\label{initialization-of-clocked-partitions} | |||
|
|
|||
| The standard scheme for initialization of Modelica models does not apply for clocked base-partitions. | |||
| The standard scheme for initialization of Modelica models does not apply for discrete-time sub-partitions. | |||
There was a problem hiding this comment.
Didn't we drop the sub here? I can't find a single example of discrete-time sub-partition in the current text?
Suggested change
| The standard scheme for initialization of Modelica models does not apply for discrete-time sub-partitions. | |
| The standard scheme for initialization of Modelica models does not apply for discrete-time partitions. |
henrikt-ma
reviewed
Sep 26, 2024
| \item | ||
| Attribute \lstinline!fixed! cannot be applied to variables in clocked partitions. | ||
| Attribute \lstinline!fixed! cannot be applied to variables in discrete-time sub-partitions. | ||
| The attribute \lstinline!fixed! is true for variables to which \lstinline!previous! is applied, otherwise false. |
There was a problem hiding this comment.
While we are at it, shouldn't we avoid the problem when previous is applied to a parameter or constant?
Suggested change
| The attribute \lstinline!fixed! is true for variables to which \lstinline!previous! is applied, otherwise false. | |
| The attribute \lstinline!fixed! is true for clocked states, otherwise false. |
henrikt-ma
reviewed
Sep 26, 2024
| \item | ||
| Attribute \lstinline!fixed! cannot be applied to variables in clocked partitions. | ||
| Attribute \lstinline!fixed! cannot be applied to variables in discrete-time sub-partitions. |
There was a problem hiding this comment.
Should we really allow fixed to be applied to clocked states in clocked discretized continuous-time partitions? Wouldn't that conflict with fixed already being defined for these variables?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on comment in modelica/ModelicaStandardLibrary#4465