Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modelica.Fluid.Sensors.BaseClasses.PartialFlowSensor should have simplified equations if allowFlowReversal = false #4436

Open
casella opened this issue Jul 20, 2024 · 0 comments
Assignees
Labels
L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)
Milestone

Comments

@casella
Copy link
Contributor

casella commented Jul 20, 2024

Modelica.Fluid.Sensors.BaseClasses.PartialFlowSensor currently contains these equations:

port_a.h_outflow = inStream(port_b.h_outflow);
port_b.h_outflow = inStream(port_a.h_outflow);
port_a.Xi_outflow = inStream(port_b.Xi_outflow);
port_b.Xi_outflow = inStream(port_a.Xi_outflow);
port_a.C_outflow = inStream(port_b.C_outflow);
port_b.C_outflow = inStream(port_a.C_outflow);

In fact, it makes no sense to compute the inStream() quantities at port_a if allowFlowReversal = false, because they will never be used. In that case, we should give them some constant default value.

@casella casella added the L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) label Jul 20, 2024
@casella casella added this to the MSL4.2.0 milestone Jul 20, 2024
@casella casella self-assigned this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)
Projects
None yet
Development

No branches or pull requests

1 participant