Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ElastoGap #4200

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Improve ElastoGap #4200

merged 1 commit into from
Dec 21, 2023

Conversation

HansOlsson
Copy link
Contributor

Closes #4197
(See that ticket for the discussion.)

@HansOlsson HansOlsson added the L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational label Sep 28, 2023
@tobolar tobolar mentioned this pull request Sep 29, 2023
Closed
christiankral
christiankral approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

tobolar
tobolar reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@tobolar tobolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f_c is negative for contact = true, i.e. when s_rel < s_rel0. This means, the contact occures when the difference s_rel-s_rel0 is negative.
IMO this implies that both f_ref and s_ref shall be limited by max = 0.

@HansOlsson
Copy link
Contributor Author

f_c is negative for contact = true, i.e. when s_rel < s_rel0. This means, the contact occures when the difference s_rel-s_rel0 is negative. IMO this implies that both f_ref and s_ref shall be limited by max = 0.

Clearly f_ref and s_ref shall have the same sign.

But I find it easier to have a positive s_ref, and the sign doesn't matter much since abs(delta) removes it.

@tobolar
Copy link
Contributor

tobolar commented Dec 15, 2023

But I find it easier to have a positive s_ref, and the sign doesn't matter much since abs(delta) removes it.

Definitely. I prepared a PR on your branch regarding this.

@tobolar tobolar self-requested a review December 15, 2023 15:54
tobolar
tobolar approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@tobolar tobolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me!

@HansOlsson
Improve ElastoGap
beac21c 
Closes modelica#4197

Prefer code to pre, and move things.

Add scaling ratio variable and add parameter description

Simplify computation of f_d

Documentation: add non-braking spaces where needed

Add scaling ratio variable and add parameter description

Simplify computation of f_d

Documentation: add non-braking spaces where needed

Improve documentation concerning s_rel and f_rel

Enable only positive values of s_rel and f_rel
@HansOlsson HansOlsson merged commit 043aaab into modelica:master Dec 21, 2023
2 checks passed
@HansOlsson HansOlsson deleted the ElastoGapUnit branch December 21, 2023 15:33
@beutlich beutlich added this to the MSL4.1.0 milestone Dec 21, 2023
@HansOlsson HansOlsson mentioned this pull request Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beutlich beutlich beutlich left review comments

@tobolar tobolar tobolar approved these changes

@christiankral christiankral christiankral approved these changes

Assignees
No one assigned
Labels
L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging this pull request may close these issues.

Unit issue in Modelica.Mechanics.Translational.Components.ElastoGap
4 participants
@HansOlsson @tobolar @christiankral @beutlich