Bump used Modelica language version to 3.6 #4208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikt-ma
added a commit
to henrikt-ma/ModelicaStandardLibrary
that referenced
this pull request
Oct 18, 2023
This reverts commit c015bfc. Bumping language version is now made the separate PR modelica#4208.
Detected by html_documentation_checks.
eshmoylova
approved these changes
Nov 14, 2023
beutlich
reviewed
Nov 14, 2023
beutlich
added
the
requires Modelica 3.6
|
It would be really good to get this merged before we tag on the 12th, since only small fixes are supposed to go into the release branch after that point. However, I don't understand the CI failure, and don't know what to do about it. To start with, I'll try pushing an empty commit… |
|
@casella, the empty commit did the trick, so this should be ready for a second approval and merging from your side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4175.
Things not covered:
ModelicaStandardLibrary/ModelicaReference/package.mo
Line 8 in 7e8ee42
I'm not convinced it is a good idea to include a statement about some parts of the language being stuck at version 3.4; it would become a real mess to sort out when to reference the version 3.4 documentation and when to reference the 3.6 documentation.
Considering that there is https://specification.modelica.org/maint/3.6/modelica-concrete-syntax.html#grammar, I wonder if this would be a good time to remove the duplication in ModelicaReference?