Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve inheritance of MultiBody constraints #4227

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve inheritance of MultiBody constraints #4227

wants to merge 3 commits into from

Conversation

tobolar
Copy link
Contributor

@tobolar tobolar commented Nov 9, 2023

Refs #3739

The intension is to rearrange PR #4091 in smaller and better evaluable portions in order to implement "selective model extension" approach after that, see also #4091 (comment)

More PRs will follow.

(This PR is generated by cherry-picking and squashing some comments of #4091 - so no new stuff here.)

@tobolar tobolar added enhancement New feature or enhancement L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody labels Nov 9, 2023
@tobolar tobolar added this to the MSL4.1.0 milestone Nov 9, 2023
@tobolar tobolar changed the title Improve inheritance of classes in MultiBody constraints Improve inheritance of MultiBody constraints Nov 9, 2023
@tobolar tobolar mentioned this pull request Nov 9, 2023
Open
@HansOlsson
Copy link
Contributor

Ah, I was a bit confused at first.
This is just normal code refactoring without selective model extension, right?

(But preparing for possibly using it.)

@tobolar
Copy link
Contributor Author

tobolar commented Nov 20, 2023 •
edited
Loading

This is just normal code refactoring without selective model extension, right?

Exactly! This is a pre-step to #4231 to make some meaningful changes from PR #4091 first (which I've changed to a draft and shall be refused later on). Doing that, this PR can be merged to the new MSL version independently of "selective model extension" progress in #4231.

#4228 is of the same idea.

Sorry for the confusion.

HansOlsson
HansOlsson reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Will just run the tests as well to confirm.

@HansOlsson HansOlsson self-requested a review December 1, 2023 10:10
HansOlsson
HansOlsson approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, including tests.

@beutlich beutlich removed their request for review January 12, 2024 21:57
@arunkumar-narasimhan
Copy link
Collaborator

@MartinOtter , could you please review this PR?

@tobolar
Copy link
Contributor Author

tobolar commented Jan 18, 2024

@MartinOtter , could you please review this PR?

IMO @beutlich could also do. See his comment #4091 (review) which refers to changes related MBS constraints (which this PR is about). So he is informed as well.

@AHaumer
Copy link
Contributor

AHaumer commented Jan 24, 2024

@MartinOtter and @HansOlsson please review and finalize this PR, otherwise agree with @tobolar on shifting the milestone.
Feel free to invite additional reviewers.

@beutlich beutlich removed their request for review January 24, 2024 21:52
@tobolar tobolar requested a review from beutlich January 25, 2024 09:58
@tobolar tobolar modified the milestones: MSL4.1.0, MSL4.2.0 Jan 26, 2024
@beutlich beutlich removed their request for review February 15, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansOlsson HansOlsson HansOlsson approved these changes

@MartinOtter MartinOtter Awaiting requested review from MartinOtter

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or enhancement L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody
Projects
None yet
Milestone
MSL4.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tobolar @HansOlsson @arunkumar-narasimhan @AHaumer