Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dimension errors in functions of Modelica.Media.Interfaces.PartialSimpleMedium #4390

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix dimension errors in functions of Modelica.Media.Interfaces.PartialSimpleMedium #4390

merged 1 commit into from
May 22, 2024

Conversation

casella
Copy link
Contributor

@casella casella commented Apr 16, 2024

See #4389.

@beutlich beutlich changed the title Fixes #4389 Fix dimension errors in functions of Modelica.Media.Interfaces.PartialSimpleMedium Apr 16, 2024
@beutlich beutlich added the L: Media Issue addresses Modelica.Media label Apr 16, 2024
beutlich
beutlich reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@beutlich beutlich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to also have a test model for all affected functions in ModelicaTest.Media.TestOnly to not break it again accidentically in the future.

HansOlsson
HansOlsson approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok.

However, the underlying design is a bit odd since setState_phX is defined as taking an input of size nX or nX-1.

But it seems too late to redesign that and I don't think a syntax such as input MassFraction X[nX or nX-1]; would be helpful!

@hubertus65 hubertus65 merged commit f5f4008 into modelica:master May 22, 2024
2 checks passed
@beutlich beutlich added this to the MSL4.2.0 milestone May 22, 2024
@casella casella mentioned this pull request Jun 27, 2024
Closed
@casella casella modified the milestones: MSL4.2.0, MSL4.1.0 Jun 28, 2024
@Esther-Devakirubai Esther-Devakirubai mentioned this pull request Aug 16, 2024
Merged
@Esther-Devakirubai
Copy link
Contributor

Backporting to maintenance branch by #4453

@beutlich beutlich modified the milestones: MSL4.1.0, maintenance Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beutlich beutlich beutlich left review comments

@HansOlsson HansOlsson HansOlsson approved these changes

@hubertus65 hubertus65 hubertus65 approved these changes

Assignees
No one assigned
Labels
L: Media Issue addresses Modelica.Media
Projects
None yet
Milestone
maintenance
Development

Successfully merging this pull request may close these issues.
5 participants
@casella @Esther-Devakirubai @HansOlsson @beutlich @hubertus65