Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comparison signals for ModelicaTest.Fluid.TestComponents.Fittings.TestJunctionTraceSubstances #4449

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

Esther-Devakirubai
Copy link
Contributor

Backport #4427

Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@arunkumar-narasimhan arunkumar-narasimhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CLAassistant
Copy link

CLAassistant commented Aug 19, 2024

CLA assistant check
All committers have signed the CLA.

@casella
Copy link
Contributor

casella commented Aug 19, 2024

@Esther-Devakirubai please sign the Contributor Licence Agreement - basically, a copyright transfer to the Modelica Association of everything which is pushed to the Modelica repositories. Strange that you managed without doing that until now or, if you've done it already, there is probably some glitch somewhere.

@Esther-Devakirubai
Copy link
Contributor Author

@Esther-Devakirubai please sign the Contributor Licence Agreement - basically, a copyright transfer to the Modelica Association of everything which is pushed to the Modelica repositories. Strange that you managed without doing that until now or, if you've done it already, there is probably some glitch somewhere.

@casella Did it. After that some checks are passed but still merge is blocked.

@casella casella merged commit 8f6cac8 into maint/4.1.x Aug 21, 2024
6 checks passed
@casella casella deleted the backport_pr4427 branch August 21, 2024 13:30
@casella
Copy link
Contributor

casella commented Aug 21, 2024

Done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants