Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to NoInit in ClockedWithDiscretizedContinuousController #4465

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change to NoInit in ClockedWithDiscretizedContinuousController #4465

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3675c4d
Change to NoInit in ClockedWithDiscretizedContinuousController
henrikt-ma Sep 10, 2024
db47055
Added fixed = true to completely specify intial conditions
casella Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...lica/Clocked/Examples/SimpleControlledDrive/ClockedWithDiscretizedContinuousController.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ model ClockedWithDiscretizedContinuousController
Clocked.RealSignals.Sampler.Sample sample1
annotation (Placement(transformation(extent={{30,-26},{18,-14}})));
Modelica.Blocks.Continuous.PI PI(
initType=Modelica.Blocks.Types.Init.InitialOutput,
y_start=0,
initType=Modelica.Blocks.Types.Init.NoInit,
casella marked this conversation as resolved.
Show resolved Hide resolved
x(fixed=true),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't x(fixed = true) a violation of this rule from https://specification.modelica.org/master/synchronous-language-elements.html#initialization-of-clocked-partitions?

Attribute fixed cannot be applied to variables in clocked partitions. The attribute fixed is true for variables to which previous is applied, otherwise false.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. So, how are initial conditions specified for such clocked partitions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a valid question, but more work on the specification side is needed to answer it. Until then, I would just find it best to avoid breaking one of the few simple rules we have.

By the way, System Modeler also warns about underdetermined initialization where PI.x was automatically selected to be initialized from start, so it is not only in Dymola that this example will not run as cleanly as we'd ideally want it to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should also mention that System Modeler is lacking a check for

Attribute fixed cannot be applied to variables in clocked partitions.

so I can't tell how close the rest of the MSL is to complying with the rule.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some more thinking I think the specification got a bit messed up when trying to clarify.

Basically I don't see how we can get this to work as desired for MSL with the current specification:

However, going back to 3.5 the rule for initial equations and fixed only applied to "clocked discrete-time partitions", which are now called "discrete-time sub-partitions". That should be restored, and we can see that example in https://specification.modelica.org/master/synchronous-language-elements.html#solver-methods has fixed=true.

Obviously we will later clarify initialization for "discrete-time sub-partitions".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "having fully defined initial conditions" is a strong requirement for tool-independent behaviour. If this is not possible with the current specification, I agree at relaxing/changing it. @HansOlsson would the proposed changes to the code OK with your proposed change to the MLS?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the proposed change to the specification there is no need to update this model at all, as the restrictions apply equally to initial equations and fixed=true.

T=0.1,
k=110)
annotation (Placement(transformation(extent={{-20,0},{0,20}})));
Expand Down