Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function Strings.contains #4493

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Add function Strings.contains #4493

merged 6 commits into from
Nov 11, 2024

Conversation

beutlich
Copy link
Member

Cherry-picked from #3247.

@beutlich beutlich added enhancement New feature or enhancement L: Utilities Issue addresses Modelica.Utilities labels Oct 27, 2024
@beutlich beutlich added this to the MSL4.2.0 milestone Oct 27, 2024
@beutlich beutlich mentioned this pull request Oct 27, 2024
Open
4 tasks
beutlich and others added 2 commits October 28, 2024 14:42
@beutlich
Fix documentation
93f22af
@beutlich @tobolar
Fix documentation
b255690 
Co-authored-by: tobolar <tobolar@users.noreply.github.com>
@beutlich beutlich requested a review from tobolar October 28, 2024 13:45
@beutlich @tobolar
Update documentation
253a3e4 
Co-authored-by: tobolar <tobolar@users.noreply.github.com>
tobolar
tobolar reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@tobolar tobolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the benefit of this function? Just to simplify calling find when a boolean output is needed?

@beutlich
Copy link
Member Author

What is the benefit of this function? Just to simplify calling find when a boolean output is needed?

Yes, it is a higher-level function. It will be used by #3247 but added here as dedicated issue for better transparency (in release notes etc.)

@beutlich beutlich requested a review from tobolar October 29, 2024 16:01
tobolar
tobolar approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@tobolar tobolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

casella
casella approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casella casella merged commit 251d7f4 into modelica:master Nov 11, 2024
11 checks passed
@beutlich beutlich mentioned this pull request Nov 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobolar tobolar tobolar approved these changes

@casella casella casella approved these changes

Assignees
No one assigned
Labels
enhancement New feature or enhancement L: Utilities Issue addresses Modelica.Utilities
Projects
None yet
Milestone
MSL4.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@beutlich @casella @tobolar @m-kessler